Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flashforge Adventurer 4 Printer Profile #8662

Merged
merged 78 commits into from
Mar 7, 2025

Conversation

urself25
Copy link
Contributor

@urself25 urself25 commented Mar 3, 2025

Description

Add Flashforge Adventurer 4 Printer Profile

Screenshots/Recordings/Graphs

image

Tests

Added to my version of Orcaslicer 2.2.0 then tried it in 2.3.0-Beta. Made it available on Github (https://github.com/urself25/OrcaSlicer_FF_AD4_Profile) for people to install by themselves, try and report any problems which all have been resolved.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Overall, the changes look good.
I made some comments, could you take a look?

@urself25 urself25 requested a review from SoftFever March 4, 2025 13:51
Copy link
Contributor Author

@urself25 urself25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made to v.2.3.0.1 json file instead of v.2.3.0.0

@SoftFever
Copy link
Owner

SoftFever commented Mar 6, 2025

Are profile "Flashforge ABS @AD4" suppose to be for Flashforge brand filament only? or it's meant for generic filament?

if they are meant for generic, better to name as "Generic ABS @AD4" so that Orca can handle the override relation. Also for the filament like "PLA SILK", please follow the name conversion in OrcaFilamentLibrary

All adjusted. for the name conversion, should I do the same for the HS to High Speed?

For HS, we can name it as Generic PLA HS @xxx pattern.
Currently it's not available in global library, but if such profile is ever added to system lib, it will be in this name pattern.

BTW, I noticed the names are still not right. It should be "Generic ABS @AD4" or "Generic ABS @FlashForge AD4"

@urself25
Copy link
Contributor Author

urself25 commented Mar 6, 2025

Are profile "Flashforge ABS @AD4" suppose to be for Flashforge brand filament only? or it's meant for generic filament?

if they are meant for generic, better to name as "Generic ABS @AD4" so that Orca can handle the override relation. Also for the filament like "PLA SILK", please follow the name conversion in OrcaFilamentLibrary

All adjusted. for the name conversion, should I do the same for the HS to High Speed?

For HS, we can name it as Generic PLA HS @xxx pattern. Currently it's not available in global library, but if such profile is ever added to system lib, it will be in this name pattern.

BTW, I noticed the names are still not right. It should be "Generic ABS @AD4" or "Generic ABS @FlashForge AD4"

Ok, I'll make the corrections on the name. As for High Speed, in the library you have this one. Generic PLA High Speed @System.json

@urself25
Copy link
Contributor Author

urself25 commented Mar 6, 2025

Are profile "Flashforge ABS @AD4" suppose to be for Flashforge brand filament only? or it's meant for generic filament?

if they are meant for generic, better to name as "Generic ABS @AD4" so that Orca can handle the override relation. Also for the filament like "PLA SILK", please follow the name conversion in OrcaFilamentLibrary

All adjusted. for the name conversion, should I do the same for the HS to High Speed?

For HS, we can name it as Generic PLA HS @xxx pattern. Currently it's not available in global library, but if such profile is ever added to system lib, it will be in this name pattern.
BTW, I noticed the names are still not right. It should be "Generic ABS @AD4" or "Generic ABS @FlashForge AD4"

Ok, I'll make the corrections on the name. As for High Speed, in the library you have this one. Generic PLA High Speed @System.json

I renamed the High Speed one and applied corrections to all the file names, filament names and in the Machine/Flashforge Adventurer 4 Series.json and in the Flashforge.json files.

@SoftFever
Copy link
Owner

Are profile "Flashforge ABS @AD4" suppose to be for Flashforge brand filament only? or it's meant for generic filament?

if they are meant for generic, better to name as "Generic ABS @AD4" so that Orca can handle the override relation. Also for the filament like "PLA SILK", please follow the name conversion in OrcaFilamentLibrary

All adjusted. for the name conversion, should I do the same for the HS to High Speed?

For HS, we can name it as Generic PLA HS @xxx pattern. Currently it's not available in global library, but if such profile is ever added to system lib, it will be in this name pattern.
BTW, I noticed the names are still not right. It should be "Generic ABS @AD4" or "Generic ABS @FlashForge AD4"

Ok, I'll make the corrections on the name. As for High Speed, in the library you have this one. Generic PLA High Speed @System.json

I renamed the High Speed one and applied corrections to all the file names, filament names and in the Machine/Flashforge Adventurer 4 Series.json and in the Flashforge.json files.

👍 Thank you for the quick response.
Names look good now.
There are some errors reported by the auto check though, can you take a look? https://github.com/SoftFever/OrcaSlicer/actions/runs/13699616525/job/38311941325?pr=8662

@urself25
Copy link
Contributor Author

urself25 commented Mar 6, 2025

👍 Thank you for the quick response. Names look good now. There are some errors reported by the auto check though, can you take a look? https://github.com/SoftFever/OrcaSlicer/actions/runs/13699616525/job/38311941325?pr=8662

Thanks.

Found the error. Forgot to change that filament name in Flashforge.json.

I must say, 6 months ago I didn't own a 3D printer. Since, I bought a used AD4, discovered Orcaslicer, learn how to create a profile for this printer. All of with with no coding knowledge. I'm an HR guy. I hope I did ok.

@SoftFever
Copy link
Owner

SoftFever commented Mar 7, 2025

Found the error. Forgot to change that filament name in Flashforge.json.

I must say, 6 months ago I didn't own a 3D printer. Since, I bought a used AD4, discovered Orcaslicer, learn how to create a profile for this printer. All of with with no coding knowledge. I'm an HR guy. I hope I did ok.

@urself25 There was a minor issue regards code_flavor remaining, but I’ve fixed it.
You did a fantastic job! Thank you for making the effort to share your profiles so other AD4 users can benefit from them.
Happy printing!

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever SoftFever merged commit bc3347a into SoftFever:main Mar 7, 2025
1 check passed
@urself25
Copy link
Contributor Author

urself25 commented Mar 7, 2025

Thanks

@urself25 urself25 deleted the urself25-FF-AD4-Profile branch March 8, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants