-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flashforge Adventurer 4 Printer Profile #8662
Conversation
resources/profiles/Flashforge/filament/Flashforge AD4 Generic ABS.json
Outdated
Show resolved
Hide resolved
resources/profiles/Flashforge/Flashforge Adventurer 4 Series_cover.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Overall, the changes look good.
I made some comments, could you take a look?
resources/profiles/Flashforge/machine/Flashforge Adventurer 4 Series 0.4 nozzle.json
Outdated
Show resolved
Hide resolved
resources/profiles/Flashforge/machine/Flashforge Adventurer 4 Series 0.4 nozzle.json
Outdated
Show resolved
Hide resolved
resources/profiles/Flashforge/machine/Flashforge Adventurer 4 Series 0.4 nozzle.json
Outdated
Show resolved
Hide resolved
Corrections for Pull request
Corrections for Pull request
Corrections for Pull request
Corrections for Pull Request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made to v.2.3.0.1 json file instead of v.2.3.0.0
For HS, we can name it as BTW, I noticed the names are still not right. It should be "Generic ABS @AD4" or "Generic ABS @FlashForge AD4" |
Ok, I'll make the corrections on the name. As for High Speed, in the library you have this one. Generic PLA High Speed @System.json |
I renamed the High Speed one and applied corrections to all the file names, filament names and in the Machine/Flashforge Adventurer 4 Series.json and in the Flashforge.json files. |
👍 Thank you for the quick response. |
Thanks. Found the error. Forgot to change that filament name in Flashforge.json. I must say, 6 months ago I didn't own a 3D printer. Since, I bought a used AD4, discovered Orcaslicer, learn how to create a profile for this printer. All of with with no coding knowledge. I'm an HR guy. I hope I did ok. |
fix gcode_flavor
@urself25 There was a minor issue regards code_flavor remaining, but I’ve fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks |
Description
Add Flashforge Adventurer 4 Printer Profile
Screenshots/Recordings/Graphs
Tests
Added to my version of Orcaslicer 2.2.0 then tried it in 2.3.0-Beta. Made it available on Github (https://github.com/urself25/OrcaSlicer_FF_AD4_Profile) for people to install by themselves, try and report any problems which all have been resolved.