Add in a pref for camera orbit speed multiplier #8725
+62
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The amount of rotation during camera orbit always struck me as too high, and I've wanted to be able to reduce it for quite a while. I suppose that this could be part of the character of slic3r, but I think it is sensible to add a pref for anyone who would like to adjust it.
I've placed this pref with the other camera prefs. It does some basic validation and formatting on the input value to keep it at two decimal places, and between a min and max of 0.05 and 2.0 respectively. This should be more than enough of a range and precision.
It defaults to 1.0 so that there is no change in the existing behavior.
Screenshots/Recordings/Graphs
Tests
I've manually verified the behavior and checked that the pref is stored into
OrcaSlicer.conffor recall.