Fix

Author: jordimas

open_dubbing/utterance.py

@@ -218,16 +218,29 @@ def _create_new_utterance(self, update, new_id):
         return new_utterance
 
     def update_utterances(self, utterance_master, utterance_update):
-        id_to_update = {}
+        id_to_update_or_delete = {}
+        id_to_create = {}
         utterance_new = []
 
         for utterance in utterance_update:
             id = utterance["id"]
-            id_to_update[id] = utterance
+            operation = utterance["operation"]
+            if operation == "create":
+                id_to_create[id] = utterance
+            else:
+                id_to_update_or_delete[id] = utterance
 
         for utterance in utterance_master:
             id = utterance["id"]
-            update = id_to_update.get(id, None)
+
+            create = id_to_create.get(id, None)
+            if create:
+                new_id = self._get_highest_id(utterance_master) + 1
+                new_utterance = self._create_new_utterance(create, new_id)
+                if new_utterance:
+                    utterance_new.append(new_utterance)
+
+            update = id_to_update_or_delete.get(id, None)
             if not update:
                 utterance_new.append(utterance)
                 continue
@@ -239,13 +252,6 @@ def update_utterances(self, utterance_master, utterance_update):
             if operation == "delete":
                 continue
 
-            if operation == "create":
-                new_id = self._get_highest_id(utterance_master) + 1
-                utterance = self._create_new_utterance(update, new_id)
-                if utterance:
-                    utterance_new.append(utterance)
-                continue
-
             if operation != "update":
                 raise ValueError(f"Invalid operation {operation}")
 

tests/utterance_test.py

@@ -210,7 +210,7 @@ def test_update_utterances_operation_create(self):
         )
         create_utterances = [
             {
-                "id": 1,  # Create after ID
+                "id": 1,  # Create before ID
                 "operation": "create",
                 "translated_text": "Bon dia",
                 "speaker_id": "SPEAKER_01",
@@ -223,8 +223,8 @@ def test_update_utterances_operation_create(self):
         new_utterances = utterance.update_utterances(master, create_utterances)
         print(f"new_utterances: {new_utterances}")
         assert len(new_utterances) == 3
-
-    #        assert new_utterances[0]["id"] == 2
+        assert new_utterances[0]["id"] == 3
+        assert new_utterances[1]["id"] == 1
 
     def test_update_utterances_operation_delete(self):