Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVSCODE-1029 fix order in HotspotResolution enum #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SLVSCODE-1029 fix order in HotspotResolution enum #693

wants to merge 1 commit into from
+1 −1

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Feb 27, 2025 •
edited by jira bot
Loading

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-1029_hotspotResolution_enum_order branch from d3bc2ff to 6edbd26 Compare February 27, 2025 10:43
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

jblievremont
jblievremont requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, the ticket is about hotspot status, not resolution 🙈

src/lsp/protocol.ts
Safe,
Fixed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the correct enum to update is a few lines below ⬇️ at 186 (it's the one mapped from the SLCORE's HotspotStatus enum)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @jblievremont