refactor: improve string formatting and remove unnecessary backticks in query classes

Author: SonyPradana

src/System/Database/MyModel/Model.php

@@ -180,7 +180,7 @@ public function setter(string $key, $value): self
     public function getter(string $key, $default = null)
     {
         if (array_key_exists($key, $this->stash)) {
-            throw new \Exception("Cant read this colum {$key}");
+            throw new \Exception("Cant read this column `{$key}`.");
         }
 
         return $this->first()[$key] ?? $default;
@@ -413,7 +413,7 @@ public function isClean(?string $column = null): bool
         foreach (array_keys($this->columns) as $key) {
             if (!array_key_exists($column, $this->columns[$key])
             || !array_key_exists($column, $this->fresh[$key])) {
-                throw new \Exception("Column {$column} is not in table {$this->table_name}");
+                throw new \Exception("Column {$column} is not in table `{$this->table_name}`.");
             }
 
             if (false === ($this->columns[$key][$column] === $this->fresh[$key][$column])) {
@@ -550,7 +550,7 @@ public function order(string $column_name, int $order_using = MyQuery::ORDER_ASC
     {
         $order = 0 === $order_using ? 'ASC' : 'DESC';
         $belong_to ??= $this->table_name;
-        $this->sort_order = "ORDER BY $belong_to.$column_name $order";
+        $this->sort_order = "ORDER BY {$belong_to}.{$column_name} {$order}";
 
         return $this;
     }

src/System/Database/MyQuery/InnerQuery.php

@@ -17,7 +17,7 @@ public function isSubQuery(): bool
 
     public function getAlias(): string
     {
-        return "{$this->table}";
+        return $this->table;
     }
 
     /** @return Bind[]  */

src/System/Database/MyQuery/Query.php

@@ -177,7 +177,7 @@ protected function splitGrupsFilters(array $group_filters): string
     protected function splitFilters(array $filters): string
     {
         $query      = [];
-        $table_name = null === $this->_sub_query ? "{$this->_table}" : $this->_sub_query->getAlias();
+        $table_name = null === $this->_sub_query ? $this->_table : $this->_sub_query->getAlias();
         foreach ($filters['filters'] as $fieldName => $fieldValue) {
             $value        = $fieldValue['value'];
             $comparation  = $fieldValue['comparation'];

src/System/Database/MyQuery/Select.php

@@ -34,11 +34,6 @@ public function __construct($table_name, array $columns_name, MyPDO $PDO, ?array
             $this->_binds = $table_name->getBind();
         }
 
-        // defaul query
-        if (count($this->_column) > 1) {
-            $this->_column = array_map(fn ($e) => "$e", $this->_column);
-        }
-
         $column       = implode(', ', $columns_name);
         $this->_query = $options['query'] ?? "SELECT {$column} FROM { $this->_sub_query}";
     }
@@ -49,7 +44,7 @@ public function __toString()
     }
 
     /**
-     * Instance of Select::class.
+     * Instance of `Select::class`.
      *
      * @param string   $table_name  Table name
      * @param string[] $column_name Selected column

src/System/Database/MyQuery/Traits/ConditionTrait.php

@@ -75,7 +75,7 @@ public function where(string $where_condition, array $binder = [])
      */
     public function between(string $column_name, $value_1, $value_2)
     {
-        $table_name = null === $this->_sub_query ? "{$this->_table}" : $this->_sub_query->getAlias();
+        $table_name = null === $this->_sub_query ? $this->_table : $this->_sub_query->getAlias();
 
         $this->where(
             "({$table_name}.{$column_name} BETWEEN :b_start AND :b_end)",

src/System/Database/MyQuery/Update.php

@@ -62,7 +62,7 @@ protected function builder(): string
         $setter = [];
         foreach ($this->_binds as $bind) {
             if ($bind->hasColumName()) {
-                $setter[] = '' . $bind->getColumnName() . ' = ' . $bind->getBind();
+                $setter[] = $bind->getColumnName() . ' = ' . $bind->getBind();
             }
         }
 

src/System/Database/MySchema/Table/Create.php

@@ -126,7 +126,7 @@ private function getPrimarykey(): array
             return [''];
         }
 
-        $primaryKeys = array_map(fn ($primaryKey) => "{$primaryKey}", $this->primaryKeys);
+        $primaryKeys = array_map(fn ($primaryKey) => $primaryKey, $this->primaryKeys);
         $primaryKeys = implode(', ', $primaryKeys);
 
         return ["PRIMARY KEY ({$primaryKeys})"];
@@ -139,8 +139,7 @@ private function getUnique(): array
             return [''];
         }
 
-        $uniques = array_map(fn ($uniques) => "{$uniques}", $this->uniques);
-        $uniques = implode(', ', $uniques);
+        $uniques = implode(', ', $this->uniques);
 
         return ["UNIQUE ({$uniques})"];
     }