BED-5249: feat: Get Tier/Label List Endpoint #1213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computator
added
enhancement
computator
force-pushed
the
BED-5249--get-asset-group-labels
branch
from
17135dd to
52b46a6
Compare
computator
force-pushed
the
BED-5249--get-asset-group-labels
branch
from
52b46a6 to
9b7c454
Compare
…--get-asset-group-labels
computator
commented
Apr 5, 2025
Comment on lines
+93
to
+94
| // TODO: use a more efficient query method | ||
| if nodelist, err := s.GraphQuery.GetNodesByKind(request.Context(), tag.ToKind()); err != nil { |
There was a problem hiding this comment.
If we end up creating the method in the referenced comment we can use it here too instead of GetNodesByKind
https://github.com/SpecterOps/BloodHound/pull/1307/files#r2027599359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail
Motivation and Context
This PR addresses: [GitHub issue or Jira ticket number]
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist: