BED-5249: feat: Get Tier/Label List Endpoint #1213
+556
−5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ package v2 | |
|
|
||
| import ( | ||
| "encoding/json" | ||
| "errors" | ||
| "fmt" | ||
| "log/slog" | ||
| "net/http" | ||
|
|
@@ -29,6 +30,7 @@ import ( | |
| "github.com/specterops/bloodhound/src/api" | ||
| "github.com/specterops/bloodhound/src/auth" | ||
| "github.com/specterops/bloodhound/src/ctx" | ||
| "github.com/specterops/bloodhound/src/database" | ||
| "github.com/specterops/bloodhound/src/model" | ||
| "github.com/specterops/bloodhound/src/queries" | ||
| "github.com/specterops/bloodhound/src/utils/validation" | ||
|
|
@@ -39,6 +41,69 @@ const ( | |
| ErrInvalidSelectorType = "invalid selector type" | ||
| ) | ||
|
|
||
| type GetAssetGroupTagsResponse struct { | ||
| AssetGroupTags model.AssetGroupTags `json:"asset_group_tags"` | ||
| Counts struct { | ||
| Selectors map[int]int `json:"selectors"` | ||
| Members map[int]int `json:"members"` | ||
| } `json:"counts,omitempty"` | ||
| } | ||
|
|
||
| func (s Resources) GetAssetGroupTags(response http.ResponseWriter, request *http.Request) { | ||
| const ( | ||
| pnameTagType = "type" | ||
| pnameIncludeCounts = "includeCounts" | ||
| ) | ||
| var ( | ||
| pvalsTagType = map[string]model.AssetGroupTagType{ | ||
| strconv.Itoa(int(model.AssetGroupTagTypeLabel)): model.AssetGroupTagTypeLabel, | ||
| strconv.Itoa(int(model.AssetGroupTagTypeTier)): model.AssetGroupTagTypeTier, | ||
| "": model.AssetGroupTagTypeAll, // default | ||
| } | ||
| pvalsIncludeCounts = map[string]bool{ | ||
|
There was a problem hiding this comment. what does the "p" stand for in these const and variable names? |
||
| "false": false, | ||
| "true": true, | ||
| "": false, // default | ||
| } | ||
| ) | ||
|
|
||
| var params = request.URL.Query() | ||
|
|
||
| if paramTagType, ok := pvalsTagType[params.Get(pnameTagType)]; !ok { | ||
| api.WriteErrorResponse(request.Context(), api.BuildErrorResponse(http.StatusBadRequest, "Invalid value specifed for tag type", request), response) | ||
| } else if paramIncludeCounts, ok := pvalsIncludeCounts[params.Get(pnameIncludeCounts)]; !ok { | ||
| api.WriteErrorResponse(request.Context(), api.BuildErrorResponse(http.StatusBadRequest, "Invalid value specifed for include counts", request), response) | ||
| } else if tags, err := s.DB.GetAssetGroupTags(request.Context(), paramTagType); err != nil && !errors.Is(err, database.ErrNotFound) { | ||
| api.HandleDatabaseError(request, response, err) | ||
| } else { | ||
| resp := GetAssetGroupTagsResponse{AssetGroupTags: tags} | ||
| if paramIncludeCounts { | ||
| ids := make([]int, 0, len(tags)) | ||
| for i := range tags { | ||
| ids = append(ids, tags[i].ID) | ||
| } | ||
| if selectorCounts, err := s.DB.GetAssetGroupTagSelectorCounts(request.Context(), ids); err != nil { | ||
| api.HandleDatabaseError(request, response, err) | ||
| return | ||
| } else { | ||
| resp.Counts.Selectors = selectorCounts | ||
| } | ||
| memberCounts := make(map[int]int, len(tags)) | ||
| for _, tag := range tags { | ||
| // TODO: use a more efficient query method | ||
| if nodelist, err := s.GraphQuery.GetNodesByKind(request.Context(), tag.ToKind()); err != nil { | ||
|
Comment on lines
+93
to
+94
There was a problem hiding this comment. If we end up creating the method in the referenced comment we can use it here too instead of https://github.com/SpecterOps/BloodHound/pull/1307/files#r2027599359 |
||
| api.HandleDatabaseError(request, response, err) | ||
| return | ||
| } else { | ||
| memberCounts[tag.ID] = nodelist.Len() | ||
| } | ||
| } | ||
| resp.Counts.Members = memberCounts | ||
| } | ||
| api.WriteBasicResponse(request.Context(), resp, http.StatusOK, response) | ||
| } | ||
| } | ||
|
|
||
| // Checks that the selector seeds are valid. | ||
| func validateSelectorSeeds(graph queries.Graph, seeds []model.SelectorSeed) error { | ||
| // all seeds must be of the same type | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can probably be private?