Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-5504: moves useIntialEnvironment to shared-ui #1290

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

benwaples
Copy link
Contributor

@benwaples benwaples commented Mar 28, 2025

Description

This PR:

  • Moved useInitialEnvironment to shared-ui so we can use it in BHE.
  • Changes useEnvironment (new hook from deep linking) return value to include environmentAggregation and environment.
  • Cleans up globally supported search param from router as its no longer needed

Motivation and Context

This PR addresses: BED-5504

Supports changes in BHE

How Has This Been Tested?

Regression tested

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

@benwaples benwaples added the user interface A pull request containing changes affecting the UI code. label Mar 28, 2025
@benwaples benwaples self-assigned this Mar 28, 2025
Comment on lines +67 to +70
environment: environmentQuery.data,
environmentAggregation,
selectEnvironment,
selectEnvironmentAggregation,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up including these properties in the return value from this hook out of convience. It allows us to get the environment as const { environment } = useSelectedEnvironment() and create a state switch with redux really easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants