BED-5266: chore: plumb tier enabled FF #1323
Conversation
| return nil | ||
| } | ||
|
|
||
| func TagAssetGroupsAndTierZero(ctx context.Context, db database.Database, graphDb graph.Database, additionalFiltersToClear ...graph.Criteria) error { |
There was a problem hiding this comment.
This offered a chance to single pathway the tagging step for asset groups and tier zero nodes which should make it that much easier to separate from "analysis"
| @@ -87,3 +88,13 @@ type GetFlagByKeyer interface { | |||
| // GetFlagByKey attempts to fetch a FeatureFlag by its key. | |||
| GetFlagByKey(context.Context, string) (FeatureFlag, error) | |||
| } | |||
|
|
|||
| // TODO Cleanup after Tiering GA | |||
| func GetTieringEnabled(ctx context.Context, service GetFlagByKeyer) bool { | |||
There was a problem hiding this comment.
My intent here was 2 fold:
- Eliminate the error handling by falling back to
falsewhich would be extremely verbose if necessary everywhere else - Create a single leverage point where the deletion of this function will force cleanup of all the other dependent areas associated with this feature flag. This should help make cleanup less sticky.
| @@ -58,6 +59,17 @@ type Node struct { | |||
| Properties *Properties `json:"properties"` | |||
| } | |||
|
|
|||
| // TODO Cleanup after Tiering GA | |||
| func (s *Node) IsTierZero() bool { | |||
There was a problem hiding this comment.
Due to cyclic entanglement, it was required to use the hardcoded strings instead of the constants.
This workaround method contains the assumption that once toggled, tagging will cleanup the other tagging approach and vice versa. Which can be seen in TagAssetGroupsAndTierZero
It was required because most of the node filtering and traversal logic cannot easily plumb db checks this deep.
| ) | ||
|
|
||
| // TODO Cleanup after Tiering GA | ||
| func SearchTierZeroNodes(tieringEnabled bool) graph.Criteria { |
There was a problem hiding this comment.
Due to cyclic entanglement, it was required to use the hardcoded strings instead of the constants.
These are leveraged across a number of filtering logic to:
a) slot in without impacting imports as the query package is where consumers were previously building these filters
b) dynamically toggle the required dawgs criteria dependent on the tagging approach
| @@ -1606,18 +1601,6 @@ func FetchAllGroupMembers(ctx context.Context, db graph.Database, targets graph. | |||
| return allGroupMembers, nil | |||
| } | |||
|
|
|||
| func FetchDomainTierZeroAssets(tx graph.Transaction, domain *graph.Node) (graph.NodeSet, error) { | |||
mistahj67
force-pushed
the
selector-engine
branch
from
8e16e20 to
41493f3
Compare
mistahj67
force-pushed
the
tiering-enabled-plumbing
branch
from
f13bac5 to
a3d00ce
Compare
Description
Motivation and Context
This PR addresses: BED-5266
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist: