chore: remove tests from just prepare-for-codereview #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNando
added
work in progress
TheNando
force-pushed
the
BED-5730--remove-tests-from-prc
branch
from
ce2b7b2 to
8d7b298
Compare
superlinkx
reviewed
Apr 15, 2025
justfile
Outdated
| @@ -65,8 +65,6 @@ _prep-steps: | |||
| @just show > tmp/repo-status.txt | |||
| @just analyze > tmp/analysis-report.txt | |||
| @just build > tmp/build-output.txt | |||
There was a problem hiding this comment.
Let's cut build too, I don't think we need it and it takes up a decent amount of time
superlinkx
approved these changes
Apr 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the yarn and go testing steps from the
just prepare-for-codereviewscript.Motivation and Context
This PR addresses: BED-5730
There was recently a discussion in the engineering-council channel to move tests to a CI check. So tests are being removed from the prc just script as to not be redundant
How Has This Been Tested?
The
just pfcscript was ran again to ensure that it still works and does not run the tests.Types of changes
Checklist: