feature/IATAB2B-48 #307
feature/IATAB2B-48 #307
Conversation
This reverts commit 0c2ffcf.
| @@ -51,10 +51,14 @@ export function getJwtVerifyCallback({ verifyOpts }: { verifyOpts?: JWTVerifyOpt | |||
|
|
|||
| const header = jwtDecode<JWTHeader>(args.jwt, { header: true }) | |||
| const payload = jwtDecode<JWTPayload>(args.jwt, { header: false }) | |||
| const kid = args.kid ?? header.kid | |||
There was a problem hiding this comment.
This is a fix from feature/IATAB2B-47 which had to be included in the deployment build
| @@ -118,80 +144,91 @@ export function getStatusListCredentialIndexStatusEndpoint(router: Router, conte | |||
| } | |||
| } | |||
| response.statusCode = 200 | |||
| return response.send({ ...entry, status }) | |||
| return response.send({ ...entry, status }) // FIXME content type? | |||
| } catch (e) { | |||
There was a problem hiding this comment.
Do we have a ticket for that or can it be fixed in this ticket?
There was a problem hiding this comment.
No ticket. Should be in scope of this ticket. The entities already know about the content-type and this is just an if else to set the header
There was a problem hiding this comment.
fixed return response.json({ ...entry, status })
@zoemaas please put the review comments in the right column in the future.
| const statusListId = updateRequest.statusListId ?? request.query.statusListId?.toString() ?? opts.statusListId | ||
| const statusListCorrelationId = updateRequest.statusListCorrelationId ?? request.query.statusListorrelationId?.toString() ?? opts.correlationId | ||
| const entryCorrelationId = updateRequest.entryCorrelationId ?? request.query.entryCorrelationId?.toString() | ||
| const credentialId = updateRequest.credentialId | ||
|
|
||
| // TODO: Move mostly to driver |
There was a problem hiding this comment.
Please create a ticket for it
There was a problem hiding this comment.
Not my comment, I do not know what the plan was exactly.
| if (proofFormat === 'jwt') { | ||
| return `application/statuslist+jwt` | ||
| } else { | ||
| return 'application/vc+ld+json' // FIXME |
There was a problem hiding this comment.
Please create a ticket for that or fix it in this one
There was a problem hiding this comment.
fixed, but have to test the impact of application/statuslist+ld+json. Added TODO on IATAB2B-52
| @@ -110,6 +110,6 @@ export class StatusList2021Entity extends StatusListEntity { | |||
| export class OAuthStatusListEntity extends StatusListEntity { | |||
| @Column({ type: 'integer', name: 'bitsPerStatus', nullable: false }) | |||
| bitsPerStatus!: number | |||
| @Column({ type: 'datetime', name: 'expiresAt', nullable: true }) | |||
| @Column({ type: process.env.DB_TYPE === 'postgres' ? 'timestamp' : 'datetime', name: 'expiresAt', nullable: true }) | |||
There was a problem hiding this comment.
We have a function for that that we use elsewhere for dates as well
There was a problem hiding this comment.
Fixed, typeOrmDateTime()
| @@ -118,80 +144,91 @@ export function getStatusListCredentialIndexStatusEndpoint(router: Router, conte | |||
| } | |||
| } | |||
| response.statusCode = 200 | |||
| return response.send({ ...entry, status }) | |||
| return response.send({ ...entry, status }) // FIXME content type? | |||
| } catch (e) { | |||
There was a problem hiding this comment.
No ticket. Should be in scope of this ticket. The entities already know about the content-type and this is just an if else to set the header
No description provided.