🐛 Lock when updating git repos

Fix #1734
SpyglassMC · Feb 20, 2025 · 3cfe460 · 3cfe460
1 parent 0b2b3a1
commit 3cfe460
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/web-api-server/package.json b/packages/web-api-server/package.json
@@ -16,6 +16,7 @@
     "start": "./bin/server.js"
   },
   "dependencies": {
+    "async-mutex": "^0.5.0",
     "chalk": "^5.4.1",
     "cors": "^2.8.5",
     "express": "^5.0.1",

diff --git a/packages/web-api-server/src/index.ts b/packages/web-api-server/src/index.ts
@@ -1,8 +1,9 @@
+import { Mutex } from 'async-mutex'
 import chalk from 'chalk'
 import cors from 'cors'
 import express from 'express'
 import { slowDown } from 'express-slow-down'
-import { fileURLToPath } from 'url'
+import { fileURLToPath } from 'node:url'
 import {
 	assertRootDir,
 	cheapRateLimiter,
@@ -23,6 +24,7 @@ const { hookSecret, port, rootDir } = loadConfig()
 await assertRootDir(rootDir)
 const gits = await initGitRepos(rootDir)
 const cache = new MemCache(gits.mcmeta)
+const gitMutex = new Mutex()
 
 const versionRoute = express.Router({ mergeParams: true })
 	.use(getVersionValidator(cache))
@@ -111,9 +113,13 @@ const app = express()
 				repository: { name: string }
 			}
 			const git = gits[name === 'vanilla-mcdoc' ? 'mcdoc' : 'mcmeta']
-			console.info(chalk.yellow(`Updating ${name}...`))
-			await git.remote(['update', '--prune'])
-			console.info(chalk.green(`Updated ${name}`))
+
+			await gitMutex.runExclusive(async () => {
+				console.info(chalk.yellow(`Updating ${name}...`))
+				await git.remote(['update', '--prune'])
+				cache.invalidate()
+				console.info(chalk.green(`Updated ${name}`))
+			})
 		},
 	)
 	.get('/favicon.ico', cheapRateLimiter, (_req, res) => {