Skip to content

Serialize Monitoring API calls #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrkm4ntr
Copy link

@mrkm4ntr mrkm4ntr commented Dec 22, 2020

Monitoring API calls of TimeSeries that have same hash should be serialized.

  • Points of same time series must be sent in order
    I got following errors from Monitoring API.
    rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: Points must be written in order. 
    One or more of the points specified had an older end time than the most recent point.: timeSeries[0-199]
    
  • Returning recoverableError or not is non-deterministic
    Returning first error in errors currently. This may drop some Points failed by recoverable errors.
    if err, ok := <-errors; ok {
    return err
    }

* Points of same time series must be sent in order
* Returning recoverableError or not is non-deterministic
@google-cla google-cla bot added the cla: yes label Dec 22, 2020
@hsmatulis hsmatulis self-assigned this Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants