Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referral contract #68

Merged
merged 8 commits into from
Feb 27, 2025
Merged

Referral contract #68

merged 8 commits into from
Feb 27, 2025

Conversation

ikemHood
Copy link
Contributor

@ikemHood ikemHood commented Feb 23, 2025

🚀 StarShop Pull Request

Mark with an x all the checkboxes that apply (like [x])


📌 Type of Change

  • Documentation (updates to README, docs, or comments)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

📝 Changes description

A Soroban smart contract implementing a sophisticated multi-level referral
system with reward tracking, commission distribution, and user verification.


📸 Evidence (A photo is required as evidence)

Screenshot 2025-02-23 at 8 19 30 AM

Test result

Screenshot 2025-02-25 at 7 44 46 AM

⏰ Time spent breakdown


🌌 Comments


Thank you for contributing to StarShop, we are glad that you have chosen us as your project of choice and we hope that you continue to contribute to this great project, so that together we can make our mark at the top!

@ikemHood ikemHood marked this pull request as draft February 23, 2025 07:25
@ikemHood ikemHood marked this pull request as ready for review February 25, 2025 06:45
Comment on lines 1 to 16
default: build

all: test

test: build
cargo test

build:
stellar contract build
@ls -l target/wasm32-unknown-unknown/release/*.wasm

fmt:
cargo fmt --all

clean:
cargo clean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file. (Makefile)

Copy link
Contributor

@aguilar1x aguilar1x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comment I left you, and also reduce the number of files, as there are too many. Good implementation, but reduce them.

@ikemHood
Copy link
Contributor Author

test_snapshot is a significant part of the file counts. should i delete those?

@aguilar1x
Copy link
Contributor

test_snapshot is a significant part of the file counts. should i delete those?

No, not that.

@ikemHood
Copy link
Contributor Author

Ok, I've tried to remove some file by restructring the codebase

@aguilar1x
Copy link
Contributor

Ok, I've tried to remove some file by restructring the codebase

Have you finished making all the changes?

@ikemHood
Copy link
Contributor Author

Yes

Copy link
Contributor

@aguilar1x aguilar1x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🫡

@aguilar1x aguilar1x merged commit 35befb1 into StarShopCr:main Feb 27, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Contract] 📂 Implement Referral System Contract
2 participants