Skip to content

test dont use #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

test dont use #3526

wants to merge 10 commits into from

Conversation

Frooodle
Copy link
Member

Description of Changes

Please provide a summary of the changes, including:

  • What was changed
  • Why the change was made
  • Any challenges encountered

Closes #(issue_number)

Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 11:21
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 14, 2025
@Frooodle
Copy link
Member Author

/deploypr security

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited
Loading

🚀 Translation Verification Summary

🔄 Reference Branch: pr-branch-messages_en_GB.properties

📃 File Check: messages_en_GB.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed
  3. Test Status: ✅ Passed

✅ Overall Check Status: Success

Thanks @Frooodle for your help in keeping the translations up to date.

@github-actions github-actions bot added Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Back End Issues related to back-end development Translation Security Security-related issues or pull requests API API-related issues or pull requests labels May 14, 2025
Copilot
Copilot AI reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces team management functionality and enhancements to the PDF table of contents editing feature while refactoring several user‐related flows. Key changes include:

  • New endpoints and repository methods to manage and assign teams.
  • UI updates in account and navigation templates to reflect team and table of contents changes.
  • Overloaded service method updates for user creation with team association.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main/resources/templates/fragments/navElements.html Added a new navbar entry for editing the table of contents.
src/main/resources/templates/account.html Redesigned account page sections, integrating API key display, admin settings banner, and settings synchronization features.
src/main/resources/static/css/modern-tables.css Introduced modern styling for data tables and related UI elements.
src/main/resources/messages_en_GB.properties Added new internationalized messages for team management and table of contents features.
src/main/java/stirling/software/SPDF/repository/UserRepository.java Added new queries supporting team-based user queries.
src/main/java/stirling/software/SPDF/repository/TeamRepository.java Introduced repository for team entities with methods to retrieve teams with related users.
src/main/java/stirling/software/SPDF/model/api/EditTableOfContentsRequest.java Extended API request object for editing PDF bookmarks.
src/main/java/stirling/software/SPDF/model/User.java & Team.java Added team association mapping between users and teams.
src/main/java/stirling/software/SPDF/controller/** Multiple controllers updated with endpoints to support team management and table of contents editing.
src/main/java/stirling/software/SPDF/config/security/** Updated security services and initial setup to include team assignment and default team creation.
LICENSE The LICENSE file has been removed.
Comments suppressed due to low confidence (1)

LICENSE:1

  • The LICENSE file has been removed, which may impact legal clarity for the project. Please confirm that this change is intentional.
MIT License

@stirlingbot
Copy link
Contributor

stirlingbot bot commented May 14, 2025

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3526
🔒 Security Enabled

This deployment will be automatically cleaned up when the PR is closed.

@Frooodle Frooodle changed the title team test dont use May 14, 2025
@Frooodle
Copy link
Member Author

/deploypr security

@stirlingbot
Copy link
Contributor

stirlingbot bot commented May 14, 2025

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3526
🔒 Security Enabled

This deployment will be automatically cleaned up when the PR is closed.

ConnorYoh
ConnorYoh reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@ConnorYoh ConnorYoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor maintainability points with a few style suggestions. Assuming you meant to delete the license file.

src/main/resources/templates/edit-table-of-contents.html
<a class="btn btn-outline-primary" data-bs-toggle="collapse" href="#info" role="button"
aria-expanded="false" aria-controls="info" th:text="#{info}"></a>
</p>
<div class="collapse" id="info">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some padding to the top of this. It's a bit squashed to the menu

src/main/resources/templates/edit-table-of-contents.html Outdated

function addBookmark(parent = null, title = '', pageNumber = 1) {
try {
console.log('Adding bookmark:', { parent, title, pageNumber });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably remove excessive logging before release

src/main/resources/templates/edit-table-of-contents.html Outdated
padding: 15px;
margin-bottom: 10px;
border: 1px solid #ced4da;
border-radius: 0.25rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the borders. Look a bit intense in dark mode. May be better if styled to appear like a table of contents which you can edit..

@Frooodle
Copy link
Member Author

/deploypr security

@stirlingbot
Copy link
Contributor

stirlingbot bot commented May 14, 2025

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3526
🔒 Security Enabled

This deployment will be automatically cleaned up when the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorYoh ConnorYoh ConnorYoh left review comments

Copilot code review Copilot Copilot left review comments

@reecebrowne reecebrowne Awaiting requested review from reecebrowne reecebrowne is a code owner

@Ludy87 Ludy87 Awaiting requested review from Ludy87 Ludy87 is a code owner

@DarioGii DarioGii Awaiting requested review from DarioGii DarioGii is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
API API-related issues or pull requests Back End Issues related to back-end development Front End Issues or pull requests related to front-end development Java Pull requests that update Java code Security Security-related issues or pull requests size:XXL This PR changes 1000+ lines, ignoring generated files. Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frooodle @ConnorYoh