Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestServer does not allow KolasuServer subclasses to be used #70

Open
loradd opened this issue Mar 7, 2024 · 1 comment
Open

TestServer does not allow KolasuServer subclasses to be used #70

loradd opened this issue Mar 7, 2024 · 1 comment
Assignees
@loradd
Labels
enhancement New feature or request

Comments

@loradd
Copy link
Contributor

loradd commented Mar 7, 2024

The current implementation of the TestServer does not allow users to customize the underlying server to use - KolasuServer is used by default. It must be possible to configure this for those cases where a KolasuServer subclass is required.

Enhancement Proposal
After a discussion with @martin-azpillaga, we propose to expose a server: KolasuServer argument in the TestServer constructor.
@loradd loradd added the enhancement New feature or request label Mar 7, 2024
@loradd loradd self-assigned this Mar 7, 2024
@loradd
Copy link
Contributor Author

loradd commented Mar 8, 2024

This might not be required given #69 @martin-azpillaga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loradd loradd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loradd