Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move external-reference to custom category #1002

Open
anderseknert opened this issue Aug 20, 2024 · 1 comment
Open

Move external-reference to custom category #1002

anderseknert opened this issue Aug 20, 2024 · 1 comment
Labels

Comments

@anderseknert
Copy link
Member

This is by far the rule we've had to make the most exceptions for in Regal, and we've heard from a few others that this has been a tad too pedandtic. While users can easily disable the rule, I think it makes sense that those who want this will have to enable it instead. Move this rule to the custom category, and make sure all references are updated.

It would be good if we can somehow allow users who have explicitly enabled this in their configuration to have it remain working without changes. Let's see if that's possible.

@anderseknert
Copy link
Member Author

OK, so having thought about this for some time — instead of moving this to the custom category, where likely few will notice or use this.. How about we change this rule to flag excessive use of external references in functions, where the value of "excessive" is configurable? And would default to something like 2-3? I do feel that anything more than that is a good occasion to consider your design, and I do think we should emphasize the main point of using functions (as opposed to rules) is that they allow dependencies to be passed as args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant