update saving strategy

Author: SunDoge

_test_args.py

@@ -3,26 +3,26 @@
 from dataclasses import dataclass
 
 # from typed_args import TypedArgs, add_argument
-import typed_args as tp
+import typed_args as ta
 import argparse
 
 logging.basicConfig(level=logging.DEBUG)
 
 
 @dataclass()
-class Args(tp.TypedArgs):
+class Args(ta.TypedArgs):
     foo: str = 'bar'
-    data: str = tp.add_argument(
+    data: str = ta.add_argument(
         metavar='DIR',
         help='path to dataset'
     )
-    arch: str = tp.add_argument(
+    arch: str = ta.add_argument(
         '-a', '--arch',
         metavar='ARCH',
         default='resnet18',
         help='model architecture (default: resnet18)'
     )
-    num_workers: int = tp.add_argument(
+    num_workers: int = ta.add_argument(
         '-j', '--workers',
         default=4,
         metavar='N',
@@ -31,7 +31,7 @@ class Args(tp.TypedArgs):
 
 @dataclass
 class Args1(Args):
-    foo: str = tp.add_argument('--foo')
+    foo: str = ta.add_argument('--foo')
 
 
 def test_args():

tests/test_add_argument.py

@@ -1,13 +1,13 @@
-import typed_args as tp
+import typed_args as ta
 import pytest
 from dataclasses import dataclass
 
 
 def test_name_or_flags():
     @dataclass
-    class Args(tp.TypedArgs):
-        foo: str = tp.add_argument('-f', '--foo')
-        bar: str = tp.add_argument()
+    class Args(ta.TypedArgs):
+        foo: str = ta.add_argument('-f', '--foo')
+        bar: str = ta.add_argument()
 
     args1 = Args.from_args(['BAR'])
     assert args1 == Args(bar='BAR')
@@ -23,17 +23,20 @@ class Args(tp.TypedArgs):
 
 def test_store_action():
     @dataclass
-    class Args(tp.TypedArgs):
-        foo: str = tp.add_argument('--foo')
+    class Args(ta.TypedArgs):
+        foo: str = ta.add_argument('--foo')
 
     args = Args.from_args('--foo 1'.split())
     assert args == Args(foo='1')
 
 
 def test_store_const_action():
     @dataclass
-    class Args(tp.TypedArgs):
-        foo: int = tp.add_argument('--foo', action='store_const', const=42)
+    class Args(ta.TypedArgs):
+        foo: int = ta.add_argument('--foo', action='store_const', const=42)
 
     args = Args.from_args(['--foo'])
     assert args == Args(foo=42)
+
+
+

tests/test_list.py

@@ -1,19 +1,33 @@
-# from typed_args import TypedArgs, add_argument, dataclass
-# from typing import List
+from typed_args import TypedArgs, add_argument
+from dataclasses import dataclass
+from typing import List
+import typed_args as ta
+import pickle
 
 
-# def test_list():
-#     """
-#     https://docs.python.org/3/library/argparse.html#nargs
-#     :return:
-#     """
+def test_list():
+    """
+    https://docs.python.org/3/library/argparse.html#nargs
+    :return:
+    """
 
-#     @dataclass()
-#     class Args(TypedArgs):
-#         foo: List[str] = add_argument('--foo', nargs=2)
-#         bar: List[str] = add_argument(nargs=1)
+    @dataclass()
+    class Args(TypedArgs):
+        foo: List[str] = add_argument('--foo', nargs=2, type=str)
+        bar: List[str] = add_argument(nargs=1, type=str)
 
-#     args = Args.from_args('c --foo a b'.split())
+    args = Args.from_args('c --foo a b'.split())
 
-#     assert args.foo == ['a', 'b']
-#     assert args.bar == ['c']
+    assert args.foo == ['a', 'b']
+    assert args.bar == ['c']
+
+
+def test_default_list():
+    @dataclass
+    class Args(ta.TypedArgs):
+        foo: int = ta.add_argument('--foo', type=int, default=42)
+        bar: List[int] = ta.add_argument(nargs='*', default=[1, 2, 3])
+
+    args = Args.from_args([])
+
+    assert args.bar == [1, 2, 3]

tests/test_pickle.py

@@ -1,13 +1,14 @@
 # from typed_args import TypedArgs, add_argument, dataclass
-import typed_args as tp
+import typed_args as ta
 import pickle
-from typing import Optional
+from typing import List, Optional
 from dataclasses import dataclass
 
 
 @dataclass()
-class Args(tp.TypedArgs):
-    foo: Optional[str] = tp.add_argument('--foo')
+class Args(ta.TypedArgs):
+    foo: Optional[str] = ta.add_argument('--foo')
+    bar: List[int] = ta.add_argument(nargs='*', default=[1, 2, 3])
 
 
 def test_pickle():

typed_args/_typed_args.py

@@ -6,6 +6,7 @@
 }
 """
 
+import dataclasses
 import inspect
 import logging
 from argparse import ArgumentParser, Namespace
@@ -151,8 +152,20 @@ def _add_argument(*args, **kwargs) -> Field:
     """
     metadata = {'type': 'add_argument', 'args': args, 'kwargs': kwargs}
     default = kwargs.get('default', None)
+
+    if isinstance(default, (list, dict, set)):
+        _logger.debug(
+            'mutable object cannot be dataclass default attribute, make default_factory'
+        )
+
+        def default_factory(): return default
+
+        default = dataclasses.MISSING
+    else:
+        default_factory = dataclasses.MISSING
+
     _logger.debug('metadata: %s', metadata)
-    return field(default=default, metadata=metadata)
+    return field(default=default, default_factory=default_factory, metadata=metadata)
 
 
 def add_parser():