fix default argument

Author: SunDoge

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.5.1]
+
+- Fix default argument. `add_argument(default=[])` now init the correct `[]` for dataclass.
+
 ## [0.5.0]
 
 - Function `add_argument` accepts `type` now and we don't check the type annotations in dataclass fields. This make `typed-args` less strict but more easy to use.
@@ -50,6 +54,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Replace attributes by name
 
 [unreleased]: https://github.com/SunDoge/typed-args
+[0.5.1]: https://github.com/SunDoge/typed-args/tree/v0.5.1
 [0.5.0]: https://github.com/SunDoge/typed-args/tree/v0.5.0
 [0.4.2]: https://github.com/SunDoge/typed-args/tree/v0.4.2
 [0.4.1]: https://github.com/SunDoge/typed-args/tree/v0.4.1

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "typed-args"
-version = "0.5.0"
+version = "0.5.1"
 description = "Parse command line arguments by defining dataclasses"
 authors = ["SunDoge <384813529@qq.com>"]
 readme = "README.md"

tests/test_list.py

@@ -27,7 +27,15 @@ def test_default_list():
     class Args(ta.TypedArgs):
         foo: int = ta.add_argument('--foo', type=int, default=42)
         bar: List[int] = ta.add_argument(nargs='*', default=[1, 2, 3])
+        config: List[str] = ta.add_argument(
+            '--config', default=[], type=str, action='append')
 
     args = Args.from_args([])
 
     assert args.bar == [1, 2, 3]
+    assert args.config == []
+
+    args1 = Args()
+    assert args1.foo == 42
+    assert args1.bar == [1, 2, 3]
+    assert args1.config == []

typed_args/__init__.py

@@ -9,4 +9,4 @@
 
 from ._typed_args import TypedArgs, add_argument
 
-__version__ = "0.5.0"
+__version__ = "0.5.1"

typed_args/_typed_args.py

@@ -165,14 +165,14 @@ def _add_argument(*args, **kwargs) -> Field:
             'mutable object cannot be dataclass default attribute, make default_factory'
         )
 
+        field_default = dataclasses.MISSING
         def default_factory(): return default
-
-        default = dataclasses.MISSING
     else:
+        field_default = default
         default_factory = dataclasses.MISSING
 
     # _logger.debug('metadata: %s', metadata)
-    return field(default=default, default_factory=default_factory, metadata=metadata)
+    return field(default=field_default, default_factory=default_factory, metadata=metadata)
 
 
 def add_parser():