Skip to content

Commit 8661d4e

Browse files
authored
Prevent potential Ascend device name buffer overflow
1 parent 6bdc385 commit 8661d4e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/extract_gpuinfo_ascend.c

+2-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ static void gpuinfo_ascend_populate_static_info(struct gpu_info *_gpu_info) {
156156
last_dcmi_return_status = dcmi_get_device_chip_info(card_id, device_id, chip_info);
157157
if (last_dcmi_return_status == DCMI_SUCCESS) {
158158
// assume Ascend only use ASCII code for chip name
159-
strcpy(static_info->device_name, (char *) chip_info->chip_name);
159+
static_info->device_name[MAX_DEVICE_NAME - 1] = '\0';
160+
strncpy(static_info->device_name, (char*) chip_info->chip_name, MAX_DEVICE_NAME - 1);
160161
SET_VALID(gpuinfo_device_name_valid, static_info->valid);
161162
}
162163
free(chip_info);

0 commit comments

Comments
 (0)