Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/fp 862 load branding from cms #63

Merged
merged 11 commits into from
Jan 28, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 28, 2021

Overview:

Load branding bar and nav bar logo from CMS.*

* CMS is not the long-term location to store header components, but at least the code is DRY-er this way than before.

PR Status:

  • Ready.

Related Jira tickets:

FP-862

Related PRs:

Summary of Changes:

  • Minor: Use modern layout code* and a variable in branding_logos.css.
  • New: Limit height of branding bar .branding-header and navigation bar .s-header.†
  • New: Add functions to importHTML.js module (for Portal and Docs).

    Minor: While in here, I also fixed an error message and a comment.

  • Minor: Rename template from branding.html to header.html.
  • New: The header.html includes new header_logo.html and header_branding.html.
  • New: The branding and logo are loaded from CMS using near-identical code.
  • New: Added new URLs for loading header_logo.html and header_branding.html in isolation (for Portal and Docs).

* Not just modern for modern's sake; this code reduces the amount of pixel-perfect values necessary (let the browser do the math).

† Naming is not consistent. Saving that for a holy grail, something like #12 (which inches closer with every PR).

Testing Steps:

See TACC/Core-Portal#334.

UI Photos:

See TACC/Core-Portal#334.

Notes:

See TACC/Core-Portal#334.

Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like header much better than branding... names with meaning? crazy!

@wesleyboar wesleyboar merged commit cab0693 into main Jan 28, 2021
@wesleyboar wesleyboar deleted the task/FP-862-load-branding-from-cms branch January 28, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants