Task/fp 862 load branding from cms

[wesleyboar]

Overview:

Load branding bar and nav bar logo from CMS.*

* CMS is not the long-term location to store header components, but at least the code is DRY-er this way than before.

PR Status:

• Ready.

Related Jira tickets:

FP-862

Related PRs:

• CMS Task/fp 862 load branding from cms Core-CMS#63
• Portal Task/fp 862 load branding from cms #334
• Docs https://bitbucket.org/taccaci/frontera-tech-docs/pull-requests/14

Summary of Changes:

• New: Update Docker image tags for CMS & Docs.
• Minor: Remove outdated and now unnecessary Portal settings.
• Minor: Rename template from navigation.html to header.html.
• New: The header.html includes new header_logo.html and header_branding.html.
• New: The branding and logo are loaded from CMS using near-identical code.

Testing Steps:

⚠︎ @tacc-wbomar has not yet tested via fresh containers and images. He tested using rsync and extra docker volumes (tricks not yet fully documented).

How to Test

See How to Test Portal/CMS/Docs Compatibility.

What to Test

1. The branding bar (top half of header) is 49px tall* (including border)…
   • on wide screen,
   • and on narrow screen.†
2. The navigation bar (bottom half of header) is 50px tall…
   • on wide screen,
   • and on narrow screen.†
3. On a narrow screen†, menu reveal matches dev.fronteraweb (or, if you test Core, dev.cep).
4. After header content load, the branding bar matches exactly across CMS, Portal, and User Guide.
5. After header content load, the logo matches exactly across CMS, Portal, and User Guide.
6. While header content dynamically loads, the branding bar and navigation bar are not resized.

* A 50px height including border is a "nice-to-have". I am saving small changes like that for the redesign (part of which is done by TACC/Core-CMS#29), during which I will greatly re-arrange styles for the better.

† A "narrow screen" is less than 1200px wide. At this screen width the navigation is hidden within a header that can be resized by clicking a toggle.

UI Photos:

Frontera

Frontera CMS

Frontera Portal

Frontera Docs

(Search Field and Portal Nav are pushed to the left because of scroll bar.)

Core

Core CMS

(Search Field being too large is a Known Issue. See TACC/Core-CMS#62.)

Core Portal

"Core" Docs

(Search Field and Portal Nav are pushed to the left because of scroll bar.)

Notes:

Known Issues

Search Field is too large on Core CMS.

See TACC/Core-CMS#62.

On narrow screen, with expanded nav menu, highlight of last CMS nav menu item is hidden by Search Bar.

Also permitted in #290. (Should be fixed during redesign.)

Disclaimer: Screenshot is from #290.

[codecov]

Codecov Report

Merging #334 (04e0fb2) into master (01d58cb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   62.13%   62.13%           
=======================================
  Files         371      371           
  Lines       11413    11409    -4     
  Branches     1858     1858           
=======================================
- Hits         7091     7089    -2     
+ Misses       4024     4022    -2     
  Partials      298      298           

Flag	Coverage Δ
javascript	63.53% <ø> (ø)
unittests	61.22% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/portal/settings/settings.py	0.00% <ø> (ø)
server/portal/settings/unit_test_settings.py	99.02% <ø> (-0.02%)	⬇️

[rstijerina]

Looks good! Is the relevant code also in core-cms?

[taoteg]

LGTM. I verified the image hashes are published in dockerhub too, so G2G!

[wesleyboar]

Looks good! Is the relevant code also in core-cms?

Late public answer. Yes. See "Related PRs", specifically TACC/Core-CMS#63.