Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: v3 #454

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

refactor: v3 #454

wants to merge 8 commits into from

Conversation

wesleyboar
Copy link
Member

Overview

Fix all the problems with Core-Styles v2.

Important

  • Styles are backwards-compatible.
  • The directory structure is not backwards-compatible.
  • The /dist directory is not committed to GitHub.

Related

Changes

Testing

UI

* feat!: remove dist

* conf!: ignore dist

* feat!: prevent publish if .css in src

Need next to:
- Rename source files to .postcss.
- Deal with demo stylesheets.

* feat: log if no dist found in source

* refactor: optimizations

* refactor: renamed vars

* refactor: renamed source .css files to .postcss

* refactor: move **/*.css source to ../*.postcss

* fix/refactor: load .postcsss not .css

* temp: restore dist (rebuilt) to diff

* revert "conf!: ignore dist" (manually)

* chore: delete & ignore dist (again)

I checked diff with base branch. All good:
- Diff had changes (unexpected).
- Diff changes were rmeoval of demo and outdated files.

* chore: ignore dist

* chore: delete util script

* fix: ignore fractal util file
* test: demo action

* feat: lint dir & worflow to do so, UNTESTED

* fix: lint workflow job step names

* test: lint workflow job name

* config: lint workflow on .css change for epic/v3

* test: build .css files

* config: output paths from repo root not fs root

* fix: delete align.css

* fix: delete admonition.css

* noop: test commit (new line)

* Revert "noop: test commit (new line)"

This reverts commit 88cf542.

* noop: test commit (new line) in a .css file

* Revert "noop: test commit (new line) in a .css file"

This reverts commit d6aa2ca.
@wesleyboar wesleyboar added enhancement Improvements or additions to existing features feature A new feature or replacement of existing feature refactor Re-writes/structures code but retains behavior major An incompatible API change labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or additions to existing features feature A new feature or replacement of existing feature major An incompatible API change refactor Re-writes/structures code but retains behavior
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant