Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usabiltity changes to QRCode Scanning Screen #533

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Conversation

JasonIsAzn
Copy link
Member

@JasonIsAzn JasonIsAzn commented Sep 13, 2024

Overview

  • Add a zoom option
  • Remove invalid qrcode checks. This will help when officers have an external qrcode next to our qrcode
  • Add a manual button to sign in/sign out (UI wise i thought this would be cool? opinions wanted)
  • Keep automatic navigation and added ui feedback

Test

  • Test Zoom feature
  • Ensure qrcode scanner still works

@JasonIsAzn JasonIsAzn added this to the Sprint 11: Summer milestone Sep 13, 2024
@JasonIsAzn JasonIsAzn linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link
Collaborator

@mestrada03 mestrada03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the Zoom in/Zoom out functionality. Seems that it works, just not enough to the point where it is noticeable. Could be a phone specific issue as well.

@JasonIsAzn JasonIsAzn marked this pull request as draft September 14, 2024 18:07
@JasonIsAzn JasonIsAzn marked this pull request as ready for review September 14, 2024 19:57
@JasonIsAzn
Copy link
Member Author

Attempting to fix zoom function. Need testing

@JasonIsAzn JasonIsAzn dismissed mestrada03’s stale review September 15, 2024 21:17

I attempted to fix zoom funciton, but need it to be tested again. Requesting another review.

@JasonIsAzn
Copy link
Member Author

completely removed zoom feature, may look into this more in the future.
Zoom feauture isn't nesserily needed after removing invalid scans. Now when we have qrcode side by side the shpe one will be detected as intended.
The only reason why we need zoom feature is for member far away from the screen, for this reason only we should still look into zoom feature.

Copy link
Collaborator

@mestrada03 mestrada03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JasonIsAzn JasonIsAzn merged commit 60ab8e6 into dev Sep 16, 2024
1 check passed
@JasonIsAzn JasonIsAzn deleted the qrcode-scanner-zoom branch September 16, 2024 01:33
@JasonIsAzn JasonIsAzn mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In-Review
Development

Successfully merging this pull request may close these issues.

QRCode: Zoom Option
2 participants