Skip to content

Commit 0d1d784

Browse files
authored
Merge pull request #42 from TBoshoven/1.16-composite-model-data
Fix for changed composite model data setup.
2 parents d7cf02e + 4931043 commit 0d1d784

File tree

2 files changed

+5
-19
lines changed

2 files changed

+5
-19
lines changed

MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/blocks/tileentities/MagicDoorwayPartBaseTileEntity.java

+4-18
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,12 @@
2424
import net.minecraftforge.api.distmarker.OnlyIn;
2525
import net.minecraftforge.client.model.CompositeModel;
2626
import net.minecraftforge.client.model.data.IModelData;
27-
import net.minecraftforge.client.model.data.ModelDataMap;
2827

2928
import javax.annotation.Nullable;
3029
import javax.annotation.ParametersAreNonnullByDefault;
3130

3231
import static com.tomboshoven.minecraft.magicdoorknob.MagicDoorknobMod.MOD_ID;
3332
import static com.tomboshoven.minecraft.magicdoorknob.modelloaders.textured.TexturedModelLoader.PROPERTY_NAMESPACE;
34-
import static net.minecraftforge.client.model.CompositeModel.SUBMODEL_DATA;
3533

3634
/**
3735
* Base class for tile entities that make up magic doorways.
@@ -49,11 +47,6 @@ public abstract class MagicDoorwayPartBaseTileEntity extends TileEntity {
4947
*/
5048
private static final ModelTextureProperty TEXTURE_HIGHLIGHT = ModelTextureProperty.get(new ResourceLocation(PROPERTY_NAMESPACE, "texture_highlight"));
5149

52-
/**
53-
* All parts of the model that need to be textured.
54-
*/
55-
private static final String[] SUBMODEL_NAMES = {"door", "doorknob", "top", "wall1", "wall2", "pillar1", "pillar2", "pillar3", "pillar4"};
56-
5750
// The block we're basing the appearance of this block on.
5851
private BlockState baseBlockState = Blocks.AIR.getDefaultState();
5952
// The doorknob that caused this block to be created.
@@ -138,17 +131,10 @@ public IModelData getModelData() {
138131
doorknobMaterial = blockMaterial;
139132
}
140133

141-
IModelData submodelData = new ModelDataMap.Builder()
142-
.withInitial(TEXTURE_MAIN, blockMaterial)
143-
.withInitial(TEXTURE_HIGHLIGHT, doorknobMaterial)
144-
.build();
145-
CompositeModel.SubmodelModelData submodelModelData = new CompositeModel.SubmodelModelData();
146-
for (String submodelName : SUBMODEL_NAMES) {
147-
submodelModelData.putSubmodelData(submodelName, submodelData);
148-
}
149-
return new ModelDataMap.Builder()
150-
.withInitial(SUBMODEL_DATA, submodelModelData)
151-
.build();
134+
CompositeModel.CompositeModelData compositeModelData = new CompositeModel.CompositeModelData();
135+
compositeModelData.setData(TEXTURE_MAIN, blockMaterial);
136+
compositeModelData.setData(TEXTURE_HIGHLIGHT, doorknobMaterial);
137+
return compositeModelData;
152138
}
153139

154140
/**

build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ subprojects {
6868
}
6969

7070
dependencies {
71-
minecraft "net.minecraftforge:forge:1.16.1-32.0.32"
71+
minecraft "net.minecraftforge:forge:1.16.1-32.0.44"
7272

7373
implementation 'com.google.code.findbugs:jsr305:3.0.2'
7474
}

0 commit comments

Comments
 (0)