Merge pull request #43 from TBoshoven/1.14-particles

TBoshoven · web-flow · commit 8d5d27832cde · 2020-07-02T19:11:40.000-04:00
Make doorway particles the right texture.
diff --git a/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/blocks/tileentities/MagicDoorwayPartBaseTileEntity.java b/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/blocks/tileentities/MagicDoorwayPartBaseTileEntity.java
@@ -4,6 +4,7 @@
 import com.tomboshoven.minecraft.magicdoorknob.items.Items;
 import com.tomboshoven.minecraft.magicdoorknob.items.MagicDoorknobItem;
 import com.tomboshoven.minecraft.magicdoorknob.modelloaders.textured.ModelTextureProperty;
+import com.tomboshoven.minecraft.magicdoorknob.modelloaders.textured.ModelTextureProperty.ModelParticleTextureProperty;
 import mcp.MethodsReturnNonnullByDefault;
 import net.minecraft.block.BlockState;
 import net.minecraft.block.Blocks;
@@ -46,6 +47,11 @@ public abstract class MagicDoorwayPartBaseTileEntity extends TileEntity {
      */
     private static final ModelTextureProperty TEXTURE_HIGHLIGHT = ModelTextureProperty.get(new ResourceLocation(PROPERTY_NAMESPACE, "texture_highlight"));
 
+    /**
+     * The particle texture of the doorway (based on base block).
+     */
+    private static final ModelParticleTextureProperty TEXTURE_PARTICLE = ModelTextureProperty.getParticleProperty();
+
     // The block we're basing the appearance of this block on.
     private BlockState baseBlockState = Blocks.AIR.getDefaultState();
     // The doorknob that caused this block to be created.
@@ -125,6 +131,7 @@ public IModelData getModelData() {
         return new ModelDataMap.Builder()
                 .withInitial(TEXTURE_MAIN, blockTexture.getName())
                 .withInitial(TEXTURE_HIGHLIGHT, doorknobTextureLocation)
+                .withInitial(TEXTURE_PARTICLE, blockTexture.getName())
                 .build();
     }
 
diff --git a/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/ITextureMapper.java b/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/ITextureMapper.java
@@ -24,4 +24,10 @@ public interface ITextureMapper {
      * @return The location of the appropriate texture
      */
     ResourceLocation mapSprite(PropertySprite spriteToMap, @Nullable BlockState blockState, @Nullable IModelData extraData);
+
+    /**
+     * @param extraData   Extra model data if available
+     * @return The location of the appropriate particle texture
+     */
+    ResourceLocation getParticleTexture(@Nullable IModelData extraData);
 }
diff --git a/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/ModelDataTextureMapper.java b/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/ModelDataTextureMapper.java
@@ -30,4 +30,16 @@ public ResourceLocation mapSprite(PropertySprite spriteToMap, @Nullable BlockSta
         }
         return new ResourceLocation("missingno");
     }
+
+    @Override
+    public ResourceLocation getParticleTexture(@Nullable IModelData extraData) {
+        if (extraData != null) {
+            ModelProperty<ResourceLocation> modelProperty = ModelTextureProperty.getParticleProperty();
+            ResourceLocation spriteLocation = extraData.getData(modelProperty);
+            if (spriteLocation != null) {
+                return spriteLocation;
+            }
+        }
+        return new ResourceLocation("missingno");
+    }
 }
diff --git a/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/ModelTextureProperty.java b/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/ModelTextureProperty.java
@@ -18,6 +18,7 @@ public final class ModelTextureProperty extends ModelProperty<ResourceLocation>
     // Lazily filled map of model texture properties.
     // Can't just use equality as they are used in an IdentityHashMap.
     private static final Map<ResourceLocation, ModelTextureProperty> PROPERTIES = Maps.newHashMap();
+    private static final ModelParticleTextureProperty PARTICLE_PROPERTY = new ModelParticleTextureProperty();
 
     private final ResourceLocation name;
 
@@ -39,6 +40,10 @@ public static ModelTextureProperty get(ResourceLocation name) {
         return PROPERTIES.computeIfAbsent(name, ModelTextureProperty::new);
     }
 
+    public static ModelParticleTextureProperty getParticleProperty() {
+        return PARTICLE_PROPERTY;
+    }
+
     @Override
     public boolean equals(Object o) {
         if (this == o) return true;
@@ -51,4 +56,6 @@ public boolean equals(Object o) {
     public int hashCode() {
         return Objects.hash(name);
     }
+
+    public static class ModelParticleTextureProperty extends ModelProperty<ResourceLocation> {}
 }
diff --git a/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/TexturedBakedModel.java b/MagicDoorknob/src/main/java/com/tomboshoven/minecraft/magicdoorknob/modelloaders/textured/TexturedBakedModel.java
@@ -21,6 +21,7 @@
 import net.minecraftforge.client.model.data.EmptyModelData;
 import net.minecraftforge.client.model.data.IModelData;
 
+import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import javax.annotation.ParametersAreNonnullByDefault;
 import java.util.List;
@@ -76,6 +77,12 @@ public ItemOverrideList getOverrides() {
         return new TexturedOverrideList(super.getOverrides());
     }
 
+    @Override
+    public TextureAtlasSprite getParticleTexture(@Nonnull IModelData data) {
+        ResourceLocation particleTextureLocation = textureMapper.getParticleTexture(data);
+        return bakedTextureGetter.apply(particleTextureLocation);
+    }
+
     /**
      * We use override lists to dynamically texture items.
      */
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_door_bottom.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_door_bottom.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "door": {
       "parent": "magic_doorknob:block/part/magic_door"
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_door_top.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_door_top.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "door": {
       "parent": "magic_doorknob:block/part/magic_door"
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_closed_bottom.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_closed_bottom.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "pillar1": {
       "parent": "magic_doorknob:block/part/magic_doorway_wall"
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_closed_top.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_closed_top.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "top": {
       "parent": "magic_doorknob:block/part/magic_doorway_top"
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_half_open_bottom.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_half_open_bottom.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "wall1": {
       "parent": "magic_doorknob:block/part/magic_doorway_wall"
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_half_open_top.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_half_open_top.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "top": {
       "parent": "magic_doorknob:block/part/magic_doorway_top"
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_open_bottom.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_open_bottom.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "pillar1": {
       "parent": "magic_doorknob:block/part/magic_doorway_pillar"
diff --git a/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_open_top.json b/MagicDoorknob/src/main/resources/assets/magic_doorknob/models/block/magic_doorway_open_top.json
@@ -1,8 +1,6 @@
 {
-  "loader": "forge:composite",
-  "textures": {
-    "particle": "minecraft:block/obsidian"
-  },
+  "loader": "magic_doorknob:textured",
+  "base_loader": "forge:composite",
   "parts": {
     "top": {
       "parent": "magic_doorknob:block/part/magic_doorway_top"

Original file line number	Diff line number	Diff line change
`@@ -30,4 +30,16 @@ public ResourceLocation mapSprite(PropertySprite spriteToMap, @Nullable BlockSta`
`30`	`30`	`}`
`31`	`31`	`return new ResourceLocation("missingno");`
`32`	`32`	`}`
	`33`	`+`
	`34`	`+ @Override`
	`35`	`+ public ResourceLocation getParticleTexture(@Nullable IModelData extraData) {`
	`36`	`+ if (extraData != null) {`
	`37`	`+ ModelProperty<ResourceLocation> modelProperty = ModelTextureProperty.getParticleProperty();`
	`38`	`+ ResourceLocation spriteLocation = extraData.getData(modelProperty);`
	`39`	`+ if (spriteLocation != null) {`
	`40`	`+ return spriteLocation;`
	`41`	`+ }`
	`42`	`+ }`
	`43`	`+ return new ResourceLocation("missingno");`
	`44`	`+ }`
`33`	`45`	`}`