Update documentation, account for Anvil changes, count start scripts as using a script, and ignore markerless icons

Author: Assumeru

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "StandardsValidator"
-version = "2.0.0"
+version = "2.0.1"
 edition = "2021"
 
 [dependencies]

Cargo.toml

@@ -66,10 +66,10 @@ This exterior cell contains a reference that, by its position, should be part of
 ### Contains broken reference
 There is something wrong with this object and it should not be used.
 
-### Contains black square despite having water
+### Contains above water black square
 Black squares are used to hide things on the minimap (as black blends in with the fog of war's color as well as the there-is-nothing-here-background's color.)
 This doesn't work very well in cells with water as those get a water texture for a background instead of the usual black.
-Which makes the black squares stand out like a sore thumb.
+Which makes the black squares stand out like a sore thumb if placed above the water.
 
 ### Contains an unlinked PrisonMarker
 This cell contains a `PrisonMarker` that doesn't link to an interior cell. `PrisonMarker`s need to link to interiors containing `stolen_goods` to prevent crashes.

WARNINGS.md

@@ -225,7 +225,7 @@
 			{ "id": "TR_m3_Aramius Marolus" }
 		] },
 		{ "model": "T_B_Imp_UNI_HairCountessAnvilPC", "rules": [
-			{ "id": "PC_i2-Anv_CountessAnv" }
+			{ "id": "PC_i2-Anv_Millona" }
 		] }
 	]
 }

data/bodyparts.json

@@ -1,5 +1,5 @@
 use std::{collections::HashMap, hash::Hash};
-use tes3::esp::{Cell, Creature, Npc, ObjectFlags, TES3Object, TravelDestination};
+use tes3::esp::{Book, Cell, Creature, Npc, ObjectFlags, TES3Object, TravelDestination};
 
 pub const CELL_SIZE: f64 = 8192.;
 const FLAG_NPC_AUTO_CALC: u32 = 0x10;
@@ -159,3 +159,12 @@ pub fn is_autocalc(npc: &Npc) -> bool {
 pub fn cannot_sleep(cell: &Cell) -> bool {
     return (cell.data.flags & FLAG_CELL_NO_SLEEP) != 0;
 }
+
+pub fn is_marker(book: &Book) -> bool {
+    if let Some(mesh) = &book.mesh {
+        return mesh.eq_ignore_ascii_case("tr\\tr_note_pin.nif")
+            || mesh.eq_ignore_ascii_case("tr\\tr_editormarker_npc.nif")
+            || mesh.eq_ignore_ascii_case("editormarker.nif");
+    }
+    return false;
+}

src/util.rs

@@ -1,18 +1,10 @@
 use super::Context;
-use crate::handlers::Handler;
+use crate::{handlers::Handler, util::is_marker};
 use std::{error::Error, fmt};
 use tes3::esp::{Book, TES3Object};
 
 pub struct BookValidator {}
 
-fn is_marker(book: &Book) -> bool {
-    if let Some(mesh) = &book.mesh {
-        return mesh.eq_ignore_ascii_case("tr\\tr_note_pin.nif")
-            || mesh.eq_ignore_ascii_case("tr\\tr_editormarker_npc.nif");
-    }
-    return false;
-}
-
 impl Handler<'_> for BookValidator {
     fn on_record(&mut self, _: &Context, record: &TES3Object, _: &str, _: &String) {
         if let TES3Object::Book(book) = record {

src/validators/books.rs

@@ -1,5 +1,5 @@
 use super::Context;
-use crate::handlers::Handler;
+use crate::{handlers::Handler, util::is_marker};
 use tes3::esp::TES3Object;
 
 pub struct FieldValidator {}
@@ -38,9 +38,11 @@ impl Handler<'_> for FieldValidator {
                 check(typename, id, "name", &r.name);
             }
             TES3Object::Book(r) => {
-                check(typename, id, "icon", &r.icon);
-                check(typename, id, "mesh", &r.mesh);
-                check(typename, id, "name", &r.name);
+                if !is_marker(r) {
+                    check(typename, id, "icon", &r.icon);
+                    check(typename, id, "mesh", &r.mesh);
+                    check(typename, id, "name", &r.name);
+                }
             }
             TES3Object::Clothing(r) => {
                 check(typename, id, "icon", &r.icon);

src/validators/missing.rs

@@ -124,6 +124,9 @@ impl Handler<'_> for OrphanValidator {
                 self.remove_script(&r.script);
                 self.objects.insert(id.to_ascii_lowercase(), typename);
             }
+            TES3Object::StartScript(r) => {
+                self.remove_script(&r.script);
+            }
             TES3Object::Static(_) => {
                 self.objects.insert(id.to_ascii_lowercase(), typename);
             }