Report underwater nodes

Author: Assumeru

WARNINGS.md

@@ -33,9 +33,6 @@ See [this bug](https://github.com/TD-Addon/TD_Addon/issues/110).
 This object contains or creates an object that is supposed to be unique to the vanilla game.
 This includes things like quest rewards and vendor chests.
 
-### Has a fog density of 0
-This can cause [graphical issues](https://en.uesp.net/wiki/Morrowind_Mod:Fogbug).
-
 ### Is not calculated for all levels
 This levelled list does not have `Calculate from all levels <= PC's level` checked, despite containing entries of different levels.
 Any entries in this list set to spawn at levels below the entries with the highest level smaller than or equal to the player's level will not appear.
@@ -125,7 +122,7 @@ This NPC is using upright Khajiit animations despite not being one of the Khajii
 ### Has multiple slave bracers
 Slaves should generally only wear a single slave bracer.
 
-## Knows spell
+### Knows spell
 This NPC knows a spell that is culturally or geographically inappropriate.
 
 ## Keys
@@ -281,6 +278,21 @@ This magic effect needs a magnitude to be useful. Might be fine if the spell is
 ### Uses effect with duration 1
 This magic effect needs a duration to be useful. Might be fine if the spell is only meant to be detected by a script.
 
+## Cells
+
+### Has a fog density of 0
+This can cause [graphical issues](https://en.uesp.net/wiki/Morrowind_Mod:Fogbug).
+
+### PathGrid contains underwater node
+Path grids that are underwater aren't used.
+
+### PathGrid contains duplicate node
+There's two nodes in the same spot. Delete one and fix the connections.
+
+### PathGrid contains unconnected node
+Nodes that aren't connected to any other nodes are useless.
+If you have a single-tile room with a locked door, just omit the path grid instead of adding a single unconnected node.
+
 # The extended validator (`--extended`)
 
 ## Ownership checks

src/validators/cells.rs

@@ -22,11 +22,12 @@ const BLACK_SQUARES: [&str; 4] = [
 pub struct CellValidator {
     seen: HashSet<String>,
     broken: HashMap<&'static str, &'static str>,
+    water_levels: HashMap<String, f32>,
 }
 
 fn get_point_coords(point: &PathGridPoint, record: &PathGrid) -> String {
-    let [x_pos, y_pos, _] = point.location;
-    let location = format!("[{}, {}]", x_pos, y_pos);
+    let [x_pos, y_pos, z_pos] = point.location;
+    let location = format!("[{}, {}, {}]", x_pos, y_pos, z_pos);
     let (x, y) = record.data.grid;
     if x != 0 || y != 0 {
         let ext_x = x_pos + x * CELL_SIZE as i32;
@@ -58,18 +59,35 @@ impl Handler<'_> for CellValidator {
                 {
                     println!("Cell {} has a fog density of 0", cell.editor_id());
                 }
+                if let Some(height) = get_water_height(cell) {
+                    self.water_levels
+                        .insert(cell.editor_id_ascii_lowercase().into_owned(), height);
+                }
             }
             TES3Object::PathGrid(pathgrid) => {
                 let points = &pathgrid.points;
                 if points.is_empty() {
                     return;
                 }
+                let cell = if pathgrid.data.grid == (0, 0) && !pathgrid.cell.is_empty() {
+                    pathgrid.cell.clone()
+                } else {
+                    pathgrid.editor_id().into_owned()
+                };
+                let water_level = self.water_levels.get(&cell.to_ascii_lowercase());
                 let mut connected: HashSet<u32> = HashSet::new();
                 connected.extend(&pathgrid.connections);
                 for (i, point) in points.iter().enumerate() {
                     if point.connection_count > 0 {
                         connected.insert(i as u32);
                     }
+                    if water_level.is_some_and(|h| (point.location[2] as f32) < *h) {
+                        println!(
+                            "PathGrid {} contains underwater node at {}",
+                            cell,
+                            get_point_coords(point, pathgrid)
+                        );
+                    }
                     for other_point in points[i + 1..].iter() {
                         if point
                             .location
@@ -79,7 +97,7 @@ impl Handler<'_> for CellValidator {
                         {
                             println!(
                                 "PathGrid {} contains duplicate node at {}",
-                                pathgrid.editor_id(),
+                                cell,
                                 get_point_coords(point, pathgrid)
                             );
                             break;
@@ -91,7 +109,7 @@ impl Handler<'_> for CellValidator {
                         if !connected.contains(&(i as u32)) {
                             println!(
                                 "PathGrid {} contains unconnected node at {}",
-                                pathgrid.editor_id(),
+                                cell,
                                 get_point_coords(point, pathgrid)
                             );
                         }
@@ -195,6 +213,7 @@ impl CellValidator {
         Self {
             seen: HashSet::new(),
             broken: get_broken_data(),
+            water_levels: HashMap::new(),
         }
     }
 }