Report (heuristic) vampires not using the right vampire head

Author: Assumeru

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "StandardsValidator"
-version = "2.1.0"
+version = "2.2.0"
 edition = "2021"
 
 [dependencies]

Cargo.toml

@@ -125,6 +125,10 @@ Slaves should generally only wear a single slave bracer.
 ### Knows spell
 This NPC knows a spell that is culturally or geographically inappropriate.
 
+### Is a vampire but uses head
+This NPC is a vampire but does not use the correct vampire head for its race.
+NPC vampires that do not need to switch to a mortal appearance should use their race's vampire head as their default head to ensure they always look like vampires.
+
 ## Keys
 A misc item is a key if it has the key flag. This is a property of the record and determines if it can be sold to merchants and detected by Detect Key.
 

WARNINGS.md

@@ -111,6 +111,30 @@ pub fn ci_starts_with(s: &str, prefix: &str) -> bool {
     false
 }
 
+pub fn ci_ends_with(s: &str, suffix: &str) -> bool {
+    if s.len() >= suffix.len() {
+        let start = s.len() - suffix.len();
+        return s.as_bytes()[start..].eq_ignore_ascii_case(suffix.as_bytes());
+    }
+    false
+}
+
+pub fn is_correct_vampire_head(head: &str, race: &str, female: bool) -> bool {
+    let prefix = "b_v_";
+    if !ci_starts_with(head, prefix) {
+        return false;
+    }
+    let without_prefix = &head[prefix.len()..];
+    if !ci_starts_with(without_prefix, race) {
+        return false;
+    }
+    let without_race = &without_prefix[race.len()..];
+    if female {
+        return "_f_head_01".eq_ignore_ascii_case(without_race);
+    }
+    "_m_head_01".eq_ignore_ascii_case(without_race)
+}
+
 pub fn update_or_insert<K, V: Default, F>(map: &mut HashMap<K, V>, key: K, f: F)
 where
     K: PartialEq,

src/util.rs

@@ -1,7 +1,7 @@
 use std::collections::HashMap;
 
 use super::Context;
-use crate::{context::Mode, handlers::Handler};
+use crate::{context::Mode, handlers::Handler, util::is_correct_vampire_head};
 use tes3::esp::{Bodypart, BodypartFlags, BodypartId, EditorId, TES3Object, TypeInfo};
 
 const VANILLA_FACTIONS: [&str; 27] = [
@@ -70,13 +70,13 @@ impl Handler<'_> for IdValidator {
         match record {
             TES3Object::Bodypart(part) => {
                 if is_vampire_head(part) {
-                    let id = format!(
-                        "b_v_{}_{}_head_01",
-                        part.race,
-                        if is_female(part) { "f" } else { "m" }
-                    );
-                    if !part.id.eq_ignore_ascii_case(&id) {
-                        println!("Bodypart {} should have id {}", part.id, id);
+                    if !is_correct_vampire_head(&part.id, &part.race, is_female(part)) {
+                        println!(
+                            "Bodypart {} should have id b_v_{}_{}_head_01",
+                            part.id,
+                            part.race,
+                            if is_female(part) { "f" } else { "m" }
+                        );
                     }
                 } else {
                     check_id(context, record);

src/validators/ids.rs

@@ -4,17 +4,18 @@ use super::Context;
 use crate::{
     context::Mode,
     handlers::Handler,
-    util::{ci_starts_with, Actor},
+    util::{ci_ends_with, ci_starts_with, is_correct_vampire_head, Actor},
 };
 use codegen::{get_joined_commands, get_khajiit_script};
 use regex::{Regex, RegexBuilder};
-use tes3::esp::{Dialogue, Npc, Script, TES3Object};
+use tes3::esp::{Dialogue, Npc, NpcFlags, Script, TES3Object};
 
 pub struct ScriptValidator {
     scripts: HashMap<String, ScriptInfo>,
     npc: Regex,
     khajiit: Regex,
     nolore: Regex,
+    vampire: Regex,
     commands: Regex,
     khajiit_script: Regex,
     projects: Vec<(&'static str, Regex)>,
@@ -29,17 +30,19 @@ struct ScriptInfo {
     npc: bool,
     khajiit: bool,
     nolore: bool,
+    vampire: bool,
     projects: Vec<&'static str>,
 }
 
 impl ScriptInfo {
-    fn new(npc: bool, khajiit: bool, nolore: bool) -> Self {
+    fn new(npc: bool, khajiit: bool, nolore: bool, vampire: bool) -> Self {
         Self {
             used: false,
             used_by_khajiit: false,
             npc,
             khajiit,
             nolore,
+            vampire,
             projects: Vec::new(),
         }
     }
@@ -56,6 +59,7 @@ impl Handler<'_> for ScriptValidator {
                 self.npc.is_match(text),
                 self.khajiit.is_match(text),
                 self.nolore.is_match(text),
+                self.vampire.is_match(text),
             );
             for (local, regex) in &self.projects {
                 if regex.is_match(text) {
@@ -75,12 +79,11 @@ impl Handler<'_> for ScriptValidator {
             }
         } else if let TES3Object::Npc(npc) = record {
             if !npc.is_dead() {
-                if !npc.script.is_empty() {
-                    let id = npc.script.to_ascii_lowercase();
-                    self.check_npc_script(npc, id);
-                    return;
+                if npc.script.is_empty() {
+                    println!("Npc {} does not have a script", npc.id);
+                } else {
+                    self.check_npc_script(npc);
                 }
-                println!("Npc {} does not have a script", npc.id);
             }
         }
     }
@@ -133,6 +136,7 @@ impl ScriptValidator {
         let npc = get_variable("T_Local_NPC", "short")?;
         let khajiit = get_variable("T_Local_Khajiit", "short")?;
         let nolore = get_variable("NoLore", "short")?;
+        let vampire = get_variable("T_Local_Vampire", "short")?;
         let commands = get_variable(get_joined_commands!(), "(short|long|float)")?;
         let khajiit_script = RegexBuilder::new(get_khajiit_script!())
             .case_insensitive(true)
@@ -157,6 +161,7 @@ impl ScriptValidator {
             npc,
             khajiit,
             nolore,
+            vampire,
             commands,
             khajiit_script,
             projects,
@@ -166,19 +171,21 @@ impl ScriptValidator {
         })
     }
 
-    fn check_npc_script(&mut self, npc: &Npc, id: String) {
-        if let Some(script) = self.scripts.get_mut(&id) {
+    fn check_npc_script(&mut self, npc: &Npc) {
+        let vampire;
+        if let Some(script) = self.scripts.get_mut(&npc.script.to_ascii_lowercase()) {
             script.used = true;
+            vampire = script.vampire;
             if !script.npc {
                 println!(
                     "Npc {} uses script {} which does not define T_Local_NPC",
-                    npc.id, id
+                    npc.id, npc.script
                 );
             }
             if !script.nolore {
                 println!(
                     "Npc {} uses script {} which does not define NoLore",
-                    npc.id, id
+                    npc.id, npc.script
                 );
             }
             let race = &npc.race;
@@ -187,17 +194,17 @@ impl ScriptValidator {
                 if !script.khajiit {
                     println!(
                         "Npc {} uses script {} which does not define T_Local_Khajiit",
-                        npc.id, id
+                        npc.id, npc.script
                     );
                 }
             }
             if script.projects.is_empty() {
-                println!("Npc {} uses script {} which does not define any province specific local variables", npc.id, id);
+                println!("Npc {} uses script {} which does not define any province specific local variables", npc.id, npc.script);
             } else if script.projects.len() > 1 {
                 println!(
                     "Npc {} uses script {} which defines {}",
                     npc.id,
-                    id,
+                    npc.script,
                     script
                         .projects
                         .iter()
@@ -206,8 +213,25 @@ impl ScriptValidator {
                         .join(", ")
                 );
             }
-        } else if !ci_starts_with(&id, "t_scnpc_") {
-            println!("Npc {} uses unknown script {}", npc.id, id);
+        } else if ci_starts_with(&npc.script, "t_scvamp_") && ci_ends_with(&npc.script, "_npc") {
+            vampire = true;
+        } else if !ci_starts_with(&npc.script, "t_scnpc_") {
+            println!("Npc {} uses unknown script {}", npc.id, npc.script);
+            return;
+        } else {
+            vampire = npc.script.contains("Vamp");
+        }
+        if vampire {
+            let has_vampire_head = is_correct_vampire_head(
+                &npc.head,
+                &npc.race,
+                npc.npc_flags.contains(NpcFlags::FEMALE),
+            );
+            let is_sneaky = npc.faction.eq_ignore_ascii_case("T_Cyr_VampirumOrder")
+                || ci_starts_with(&npc.script, "T_ScNpc_Cyr_");
+            if !has_vampire_head && !is_sneaky {
+                println!("Npc {} is a vampire but uses head {}", npc.id, npc.head);
+            }
         }
     }