Add database support to plantUML #1133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfij
commented
Jul 5, 2023
| private static final String ALIAS_GROUP_NAME = "alias"; | ||
| private static final String ALIAS_FORMAT = "\\s*(?:as \"?" + capture("[^\" ]+", ALIAS_GROUP_NAME) + "\"?)?"; | ||
|
|
||
| private static final String COLOR_FORMAT = "\\s*(?:#" + anyOf("\\w|/\\\\-") + "+)?"; | ||
|
|
||
| private static final String COMPONENT_TYPE_GROUP_NAME = "componentType"; | ||
| private static final String COMPONENT_TYPE_FORMAT = capture("component", COMPONENT_TYPE_GROUP_NAME) + "?"; |
There was a problem hiding this comment.
a component keyword is optional and lib should support both
[Comp1] <<..c1..>>
and
component [Comp1] <<..c1..>>
Currently, it supports only the first option.
Issue: TNG#1132 Signed-off-by: Tomasz Fijalkowski <3066563+tfij@users.noreply.github.com>
|
hi @codecholeric |
|
@codecholeric and @hankem |
bgalek
approved these changes
Sep 15, 2023
|
Superseded by #1184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1132
Please review this change. If it is ok I'll add more tests.