replace JarURLConnection.getJarFileURL() by .getURL()
#1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For typical plain JAR URLs this doesn't make a real difference, but for special JAR URLs, like Spring Boot uses, it does. The problem showed with nested JAR URLs of Spring Boot. Those have a format like ``` jar:nested:/some/file.jar/!BOOT-INF/lib/nested.jar!/com/example/MyClass.class ``` Here the `connection.getJarFileURL()` is ``` nested:/some/file.jar/!BOOT-INF/lib/nested.jar ``` but the `connection.getURL()` is ``` jar:nested:/some/file.jar/!BOOT-INF/lib/nested.jar!/ ``` Using the latter yields the correct result and allows the custom JAR URL handler to kick in. Using the former will yield an exception that ArchUnit doesn't understand the scheme `nested`. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For typical plain JAR URLs this doesn't make a real difference, but for special JAR URLs, like Spring Boot uses, it does. The problem showed with nested JAR URLs of Spring Boot. Those have a format like
Here the
connection.getJarFileURL()isbut the
connection.getURL()isUsing the latter yields the correct result and allows the custom JAR URL handler to kick in. Using the former will yield an exception that ArchUnit doesn't understand the scheme
nested.Resolves: #1224