fix issues with build dependencies and test execution #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecholeric
force-pushed
the
fix-build-execution
branch
from
e6f34f8 to
7584c41
Compare
Before GitHub offered Windows runners we had to use Jenkins from time to time to run the tests on Windows slaves. This hasn't been used anymore for years and I don't see any reason to maintain this anymore. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
Strangely this still worked in many cases, even though `jdk9main` is depending on the output of the regular `main` source set, since it's reusing some of the code. When I tried to run `./gradlew test` alone now, `:archunit:compileJdk9mainJava` constantly failed unless this setting was fixed. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
When migrating the build configuration to plugins, we accidentally disabled JUnit 5 tests being executed during CI. Since we don't have many such tests and nothing ever broke there, this went unnoticed until now. The reason is that there is a generic piece of configuration in `java-testing-conventions.gradle` that reacts to `archUnitTest.hasSlowTests == true`, and if `true` and the property `allTests` not set, configures JUnit 4 to exclude the Category `Slow`. Unfortunately, this also switches the test execution completely back to JUnit 4, disabling any JUnit 5 tests to be run. And since we configure this in `afterEvaluate`, it actually overwrites the test configuration of the concrete module. Ironically, we don't even have any `Slow` tests in modules where we use JUnit 5. Thus, we can simply disable `archUnitTest.hasSlowTests` for those. We include a check for now to make sure that this will never be set again for modules that contain JUnit 5 tests. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
We don't have any slow tests in this module, so we don't need any slow test configuration. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
codecholeric
force-pushed
the
fix-build-execution
branch
from
7584c41 to
96d38be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some parts of the build are broken:
jdk9maindoesn't declare its dependency on the compiled classes ofmainwhich randomly leads to build failsThis fixes both these issues and removes some obsolete configuration from the build.