Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified Slices documentation #1366

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Clarified Slices documentation #1366

merged 1 commit into from
Jan 25, 2025

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Oct 19, 2024

The slices documentation does not mention a very important aspect, that is that, technically, Slices do not represent a given set of packages, although the example shows that.

@hankem
Copy link
Member

hankem commented Jan 17, 2025

Thanks for your contribution! 🙏 Sorry that this PR has been overlooked for so long... 🙈

Could you please sign-off your commit according to the DCO, cf. Contributing guideline?

@mipo256
Copy link
Contributor Author

mipo256 commented Jan 17, 2025

Hey @hankem, yeah, sure, I've signed off the commit

@mipo256
Copy link
Contributor Author

mipo256 commented Jan 17, 2025

@hankem done :)

@hankem
Copy link
Member

hankem commented Jan 17, 2025

Oh, and one more request (sorry! 🙈): Could you please rebase your branch onto the current main branch?
GitHub might not let me merge it while this branch is out-of-date with the base branch.

@mipo256
Copy link
Contributor Author

mipo256 commented Jan 19, 2025

oops, sorry, I'll reopen it :)

CC: @hankem done, rebased

@mipo256 mipo256 reopened this Jan 19, 2025
@mipo256
Copy link
Contributor Author

mipo256 commented Jan 20, 2025

I applied the suggestion, and the commit is signed off, it is strange that the DCO is red...

@mipo256 mipo256 requested a review from hankem January 20, 2025 09:38
Copy link
Member

@hankem hankem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the DCO check was confused because of the discrepancy of the author (you), commiter (me), and sign-off (you, with another name and email address)?
But I think that it should be fine; I found a setting to set the check to pass.

@hankem hankem removed the request for review from codecholeric January 23, 2025 07:30
@hankem hankem dismissed codecholeric’s stale review January 23, 2025 07:31

Requested changes have been applied. I'll try to get this merged.

@hankem hankem enabled auto-merge (rebase) January 23, 2025 07:31
@hankem hankem disabled auto-merge January 23, 2025 07:32
@hankem
Copy link
Member

hankem commented Jan 23, 2025

@mipo256, could you allow edits from maintainers (or rebase to main once again)?

GitHub doesn't let me merge this PR because
it is out-of-date with the base branch

The slices documentation does not mention a very important aspect, that is that, technically, Slices do not represent a given set of packages, although the example shows that.

Signed-off-by: mipo256 <mikhailpolivakha@gmail.com>
@mipo256
Copy link
Contributor Author

mipo256 commented Jan 23, 2025

Rebased @hankem

@mipo256 mipo256 reopened this Jan 23, 2025
@hankem hankem merged commit 070c786 into TNG:main Jan 25, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants