Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .NET 9.0 and manage NuGet packages centrally #22

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

TSRBerry
Copy link
Owner

This PR updates all the projects to target .NET 9.0 and adds Directory.Packages.props to make managing NuGet packages easier.

We are updating to .NET 9.0 to get support for partial properties, which is pretty exciting for source generators!

Copy link
Contributor

@AnonymusNW AnonymusNW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -37,7 +37,7 @@ The full changelog is available at: https://github.com/TSRBerry/RyuSOCKS/blob/ma
</ItemGroup>

<ItemGroup>
<PackageReference Include="NetCoreServer" Version="8.0.7" />
<PackageReference Include="NetCoreServer" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the version not required anymore?
I assume this is due to not needing a specific older NetCoreServer version and just using the newest one.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions are now specified in Directory.Packages.props

@TSRBerry TSRBerry merged commit 09f8ced into dev Dec 12, 2024
4 checks passed
@TSRBerry TSRBerry deleted the feature/dotnet-9.0 branch December 12, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants