Grab Bag of CLI refactorings #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `system` dealt with as many systems as were available (i.e. multiple). As such, it makes sense for it to be plural, hence `systems`.
Previously anytime a system arg was passed to a command, we rewrote the system loading logic. Now anytime the system arg is used, as part of that process the rule system will automatically get loaded.
Previously it was under `systems gen stat-block`. However the nesting under `systems was unnecessary. For now we're gonna put generation commands that don't have a distinct generation association under the base `gen` command.
With the removal of `gen` CLI subcommand of `systems` in the previous commit, the only sub command being handled by the "general" `handle_systems_subcommands` method was `:show`. As such, it made sense to flatten the child function being called into a patterned matched on `:show` version of `handle_systems_subcommands`. Of note, this seems to be a generally useful pattern, that is having handling functions pattern match on the command. If we expanded this paradigm to subcommands, we'd approach a system which each command + sub-command combo chain has it's own individual handler. If that becomes the rule, it might make sense to extend `optimus` such that leaf commands simply define their handler in the spec. This would elimate the need for functions which mostly seem to becoming routing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there an associated github issue?
No
What is this PR changing?
The provided CLI was a bit disorganized / inconsistent in its patterns. This PR is just to do a bit of cleanup
systemtosystemslist-systemsintosystemscommandcharacterscommandsystem_parsercustom arg parser to reduce code duplication