Call本体機能の追加 #794
Draft
Call本体機能の追加 #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NePonpon
added
優先度: 高い
レビュープリーズ
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR implements the call functionality by migrating Call‐system components to the AI space and updating corresponding identifiers.
- Updated GitHub workflow YAML configuration for improved multi‐line formatting.
- Renamed skill identifiers from legacy “skill:enemy/” prefixes to the new “ai:skill/” pattern.
- Minor formatting adjustments in the YAML file to enhance clarity and consistency.
Files not reviewed (19)
- data/ai/function/call/call.mcfunction: Language not supported
- data/ai/function/call/condition/condition/.mcfunction: Language not supported
- data/ai/function/call/condition/condition/check_block.mcfunction: Language not supported
- data/ai/function/call/condition/condition/check_nbt.mcfunction: Language not supported
- data/ai/function/call/condition/condition/function.mcfunction: Language not supported
- data/ai/function/call/condition/condition/hp.mcfunction: Language not supported
- data/ai/function/call/condition/condition/min_hp.mcfunction: Language not supported
- data/ai/function/call/condition/condition/min_lv.mcfunction: Language not supported
- data/ai/function/call/condition/condition/min_mp.mcfunction: Language not supported
- data/ai/function/call/condition/condition/mp.mcfunction: Language not supported
- data/ai/function/call/condition/condition/random_chance.mcfunction: Language not supported
- data/ai/function/call/condition/condition/target/.mcfunction: Language not supported
- data/ai/function/call/condition/condition/target/half.mcfunction: Language not supported
- data/ai/function/call/condition/logic/.mcfunction: Language not supported
- data/ai/function/call/condition/logic/and.mcfunction: Language not supported
- data/ai/function/call/condition/logic/or.mcfunction: Language not supported
- data/ai/function/call/condition/logic/single.mcfunction: Language not supported
- data/ai/function/call/execute/.mcfunction: Language not supported
- data/ai/function/call/execute/all.mcfunction: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/chatgpt-review.yml:136
- [nitpick] The renaming to the 'ai:skill' prefix enhances consistency; please verify that this update is reflected uniformly across relevant documentation and references.
- - `ai:skill/laser/loop/security_laser`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケット URL
GH-790
対応内容・対応背景・妥協点
skill:enemy/にあったスキル実装をai空間へ移動する。やったこと
functions->functionenemy:ai/call/->ai:/call/skill:enemy/->ai:skill/やってないこと
テスト
Functionを使っていてその中身が更新されていない場合の動作は保証されませんレビュー観点
チェックリスト (ガイドライン)