Skip to content

refactor: revert onSuccess/onError/onMutate/onSettled callback types to Promise<unknown> | unknown #9251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

refactor: revert onSuccess/onError/onMutate/onSettled callback types to Promise<unknown> | unknown #9251

merged 1 commit into from
Jun 5, 2025

Conversation

braden-w
Copy link
Contributor

@braden-w braden-w commented Jun 5, 2025

This reverts commit 982f6ca, following discussion in #9202 and #9245.

@braden-w
Revert "refactor(types): narrow onSuccess/onError/onMutate/onSettled …
fa828a0 
…callback types to Promise<void> | void (TanStack#9202)"

This reverts commit 982f6ca.
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fa828a0.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 58s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 44s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-05 00:20:04 UTC

@braden-w braden-w mentioned this pull request Jun 5, 2025
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 5, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9251

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9251

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9251

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9251

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9251

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9251

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9251

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9251

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9251

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9251

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9251

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9251

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9251

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9251

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9251

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9251

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9251

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9251

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9251

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9251

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9251

commit: fa828a0

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.68%. Comparing base (5e3cd46) to head (fa828a0).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9251       +/-   ##
===========================================
+ Coverage   45.33%   59.68%   +14.34%     
===========================================
  Files         207      136       -71     
  Lines        8271     5514     -2757     
  Branches     1865     1485      -380     
===========================================
- Hits         3750     3291      -459     
+ Misses       4080     1925     -2155     
+ Partials      441      298      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.00% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 98.15% <ø> (ø)
@tanstack/query-devtools 3.55% <ø> (ø)
@tanstack/query-persist-client-core 79.47% <ø> (+1.14%) ⬆️
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.93% <ø> (-0.10%) ⬇️
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.13% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.07% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.10% <ø> (+0.24%) ⬆️
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@braden-w braden-w mentioned this pull request Jun 5, 2025
Merged
@TkDodo TkDodo merged commit dfbda9d into TanStack:main Jun 5, 2025
7 checks passed
braden-w added a commit to epicenterhq/query that referenced this pull request Jun 9, 2025
@braden-w
refactor: complete MaybePromise<T> migration and update mutation call…
cdcaad4 
…back return types

- Convert remaining T | Promise<T> patterns to MaybePromise<T> in streamedQuery and mutation options
- Update mutation callback return types from MaybePromise<void> to MaybePromise<unknown> to mirror TanStack#9251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation package: query-core package: react-query-persist-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braden-w @TkDodo