Skip to content

Commit

Permalink
Merge pull request #66 from Team-Lecue/modify/#64-check_nickname_dup
Browse files Browse the repository at this point in the history
[FEAT] 닉네임 중복 에러로그 출력
  • Loading branch information
dong2ast authored Jan 16, 2024
2 parents 8d80f02 + e7d1568 commit 884fc8a
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ public interface MemberRepository extends JpaRepository<Member, Long> {

Optional<Member> findBySocialPlatformAndSocialId(SocialPlatform socialPlatform, String socialId);

boolean existsByNickname(String nickname);



default Member findByIdOrThrow(Long id) {
return this.findById(id)
.orElseThrow(() -> new CustomException(ErrorType.NOT_FOUND_MEMBER_ERROR));
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
package org.sopt.lequuServer.domain.member.service;

import static org.sopt.lequuServer.global.exception.enums.ErrorType.INVALID_SOCIAL_ACCESS_TOKEN;
import static org.sopt.lequuServer.global.exception.enums.ErrorType.INVALID_TOKEN_HEADER_ERROR;
import static org.sopt.lequuServer.global.exception.enums.ErrorType.NOT_FOUND_MEMBER_ERROR;

import java.util.List;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.sopt.lequuServer.domain.book.model.Book;
Expand All @@ -18,14 +23,11 @@
import org.sopt.lequuServer.global.auth.jwt.TokenDto;
import org.sopt.lequuServer.global.auth.security.UserAuthentication;
import org.sopt.lequuServer.global.common.logging.LoggingMessage;
import org.sopt.lequuServer.global.exception.enums.ErrorType;
import org.sopt.lequuServer.global.exception.model.CustomException;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

import java.util.List;

import static org.sopt.lequuServer.global.exception.enums.ErrorType.*;

@Slf4j
@Service
@RequiredArgsConstructor
Expand Down Expand Up @@ -118,7 +120,12 @@ private static String parseTokenString(String tokenString) {

@Transactional
public MemberNicknameResponseDto setMemberNickname(Long memberId, MemberNicknameRequestDto request) {
if (memberRepository.existsByNickname(request.nickname())) {
throw new CustomException(ErrorType.NICKNAME_DUP_ERROR);
}

Member member = memberRepository.findByIdOrThrow(memberId);

member.updateNickname(request.nickname().strip());
return MemberNicknameResponseDto.of(memberId);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ public enum ErrorType {
NOT_FOUND_BOOK_ERROR(HttpStatus.NOT_FOUND, "존재하지 않는 레큐북입니다."),
NOT_FOUND_STICKER_ERROR(HttpStatus.NOT_FOUND, "존재하지 않는 스티커입니다."),

/**
* 409 CONFLICT
*/
NICKNAME_DUP_ERROR(HttpStatus.CONFLICT, "중복된 회원 닉네임입니다."),


/**
* 500 INTERNAL SERVER ERROR
*/
Expand Down

0 comments on commit 884fc8a

Please sign in to comment.