Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#101 [fix] 행복루틴 QA 이슈 해결 #128

Merged
merged 26 commits into from
Jan 19, 2024

Conversation

pump9918
Copy link
Collaborator

@pump9918 pump9918 commented Jan 19, 2024

📑 Work Description

  • 카드 규격이 약간 안맞음(HappyDetailActivity)
  • HappyDetailActivity의 바텀시트 이미지가 틀림
  • HappyListActivity 위 item에 기본 이미지 넣기
  • 뒤로가기 터치 영역 늘리기
  • 전체 버튼 디폴트로 눌려있게

🛠️ Issue

📷 Screenshot

Screen_Recording_20240119_215704_Softie.mp4

💬 To Reviewers

…appy-routine

# Conflicts:
#	app/src/main/java/com/sopetit/softie/ui/happyroutine/HappyMyRoutineFragment.kt
#	app/src/main/java/com/sopetit/softie/ui/happyroutine/HappyRoutineFragment.kt
#	app/src/main/java/com/sopetit/softie/ui/happyroutine/list/HappyAddListChipContentAdapter.kt
#	app/src/main/java/com/sopetit/softie/ui/happyroutine/list/HappyAddListContentAdapter.kt
@pump9918 pump9918 self-assigned this Jan 19, 2024
@pump9918 pump9918 added UI ui 관련 작업 호연🐻‍❄️ 호연이가 작업함! labels Jan 19, 2024
Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왕왕 수고하셨슴다!

Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿구웃

Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뷰페이저 부분은 좀 더 고민해봅시다!

@pump9918 pump9918 added fix Fix(디자인 등) and removed UI ui 관련 작업 labels Jan 19, 2024
@pump9918 pump9918 merged commit 74e2b37 into develop Jan 19, 2024
1 check passed
@pump9918 pump9918 deleted the feature/#101-fix-happy-routine branch January 19, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix(디자인 등) 호연🐻‍❄️ 호연이가 작업함!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[fix] 행복루틴 QA 이슈 해결
4 participants