#133 [fix] 닉네임 숫자 방지 및 10글자 경고문 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pump9918
approved these changes
Jan 28, 2024
| private const val MAXIMUM_LENGTH = 10 | ||
| private const val NICKNAME_PATTERN = | ||
| "^[ㄱ-ㅣ가-힣a-zA-Z\\u318D\\u119E\\u11A2\\u2022\\u2025\\u00B7\\uFE550-9]{1,10}\$" | ||
| "^[ㄱ-ㅣ가-힣a-zA-Z\\u318D\\u119E\\u11A2\\u2022\\u2025\\u00B7]{1,10}\$" |
There was a problem hiding this comment.
이런 정규표현식은 보통 어디에서 구하시나요?
There was a problem hiding this comment.
구글링과 지선생 씁니다ㅎㅎ
| } | ||
|
|
||
| private fun handleInvalidInput(source: CharSequence) = |
minemi00
approved these changes
Jan 29, 2024
| } | ||
|
|
||
| private fun handleInvalidInput(source: CharSequence) = |
emjayMJkim
approved these changes
Jan 30, 2024
Comment on lines
+58
to
+61
| private fun clearWarningFlags() { | ||
| setInvalidInputWarning(false) | ||
| setLengthExceedWarning(false) | ||
| } |
There was a problem hiding this comment.
경고문을 띄우지 않는 경우에는 false로 설정해줘야 안 뜨기 때문입니다!!
| _isWarning.value = | ||
| (_isSpecialCharacterEntered.value == true) || (_isLengthExceed.value == true) | ||
| (isInvalidInput.value == true) || (isLengthExceed.value == true) |
There was a problem hiding this comment.
정규식에서 글자 길이도 제한을 뒀는데 isLengthExceed를 따로 설정하는 이유가 있을까요?
There was a problem hiding this comment.
그게 안먹어서요,, 저도 이유는 모르겠습니다 ^-ㅜ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
record_nickname.mp4
💬 To Reviewers
생각보다 짜치는 처리였달까.. filter가 너무 많아요! ㅠ