#136 [fix] 릴리즈 전 데일리 루틴 이슈 수정 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-halo
approved these changes
Jan 30, 2024
Comment on lines
+284
to
+286
| binding.root.rootView, | ||
| getString(R.string.daily_routine_add_snack_bar), | ||
| (requireActivity() as MainActivity).findViewById(R.id.bottom_navigation_home) |
Comment on lines
-96
to
-105
| val dp = resources.getDimensionPixelSize(R.dimen.view_margin) | ||
| val d = resources.displayMetrics.density | ||
| val margin = (dp * d * 1.3).toInt() | ||
|
|
||
| with(binding.vpDailyRoutineAddCard) { | ||
| clipChildren = false | ||
| clipToPadding = false | ||
| offscreenPageLimit = VIEW_PAGE.toInt() | ||
| setPadding(margin, PADDING_CARD, margin, PADDING_CARD) | ||
| } |
There was a problem hiding this comment.
지긋지긋한 뷰페이저,, 고생하셨습니다.
Comment on lines
134
to
136
| title = "데일리 루틴을 완료했나요?", | ||
| content = "한 번 완료하면 이전으로 되돌릴 수 없어요", | ||
| title = getString(R.string.daily_routine_complete), | ||
| content = getString(R.string.daily_routine_complete_notice), |
app/src/main/res/values/strings.xml
Outdated
| @@ -148,6 +149,10 @@ | |||
| <string name="daily_routine_fin">달성완료</string> | |||
| <string name="daily_routine_complete_title">데일리 루틴을 완료했어요!</string> | |||
| <string name="daily_routine_complete_subtitle">솜뭉치 1개 획득</string> | |||
| <string name="daily_routine_complete">데일리 루틴을 완료했나요?</string> | |||
There was a problem hiding this comment.
별 건 아니지만 daily_routine_complete_title 이렇게 수정하시는 건 어떤가요? 는 이미 비슷한 게 있군요,,
그럼 아래 쓰셨던 것 처럼
daily_routine_complete_yet_title
daily_routine_complete_fix_title
대충 이런 식으로 처리해보시는 건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_recording_20240130_144539.mp4
Screen_recording_20240201_161228.mp4
💬 To Reviewers
기본이미지로 박아놓으니까 카드는 로딩 비슷한거 같은데 테마 아이콘은 로딩이 훨 느려진것같슴다..
두번째 영상 완료하기 버튼 누르는 중 입니다..ㅎ