#135 [fix] 릴리즈 전 QA 이슈 수정 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-halo
requested changes
Jan 31, 2024
Comment on lines
61
to
62
| android:layout_width="208dp" | ||
| android:layout_height="208dp" |
There was a problem hiding this comment.
고정 dp 쓰지 마시고 margin으로 조정해주세요!
+dimenRatio도 써서 조절해주세요~
minemi00
approved these changes
Jan 31, 2024
stellar-halo
approved these changes
Jan 31, 2024
Comment on lines
+77
to
+82
| private fun initSetNickNameObserver() { | ||
| viewModel.nickname.observe(viewLifecycleOwner) { | ||
| viewModel.checkIsNickNameValid() | ||
| } | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
fix.recyclerciew.multi.selection.mp4
💬 To Reviewers
이런저런 방법 써보고.. selection tracker도 써봤는데.. 결국 좀 허무하게 해결이 된 것 같네요..
일단 스크롤시 재사용으로 인한 다중클릭 이슈는 해결 했는데, 혹시나 다른 문제가 생기면 바로 해결하겠습니닷