Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#22 [fix] 투명 상태바 적용 #24

Merged
merged 7 commits into from
Jan 10, 2024
Merged

#22 [fix] 투명 상태바 적용 #24

merged 7 commits into from
Jan 10, 2024

Conversation

stellar-halo
Copy link
Contributor

@stellar-halo stellar-halo commented Jan 10, 2024 •
edited
Loading

📑 Work Description

  • 상태바가 색상이 자주 바뀌어 투명하게 바꿨습니다!

🛠️ Issue

📷 Screenshot

image
image
image

💬 To Reviewers

  • 상태바가 투명해짐 + 영역 없어짐으로 figma에서 상태바 포함해서 dp 작업해주세요! 지금까지 작업하셨던 것들도 top_toTop="parent"를 걸어준 컴포넌트들이 있다면 marginTop 바꿔주시면 될 듯 합니다!
  • 해당 작업을 위해 activity xml에서 최상위 layout에 android:fitsSystemWindows="true" 속성을 작성해주세요!

@stellar-halo stellar-halo self-assigned this Jan 10, 2024
@stellar-halo stellar-halo marked this pull request as draft January 10, 2024 08:09
@stellar-halo stellar-halo marked this pull request as ready for review January 10, 2024 08:33
emjayMJkim
emjayMJkim approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당

minemi00
minemi00 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당 다 코드 추가하도록 하겠습니당

pump9918
pump9918 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~ 고생했어요!

@stellar-halo stellar-halo merged commit c81c2f8 into develop Jan 10, 2024
1 check passed
@stellar-halo stellar-halo deleted the feature/#22-status-bar-transparent branch January 10, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pump9918 pump9918 pump9918 approved these changes

@emjayMJkim emjayMJkim emjayMJkim approved these changes

@minemi00 minemi00 minemi00 approved these changes

Assignees

@stellar-halo stellar-halo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] status bar 투명하게 변경
4 participants
@stellar-halo @pump9918 @emjayMJkim @minemi00