#46 [ui] 루틴 완료 시 보이는 화면 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tine-complete # Conflicts: # app/src/main/AndroidManifest.xml
…tine-complete # Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/sopetit/softie/ui/dailyroutine/DailyRoutineFragment.kt # app/src/main/java/com/sopetit/softie/ui/happyroutine/addlist/HappyAddListViewModel.kt
minemi00
approved these changes
Jan 14, 2024
Comment on lines
+37
to
+42
| private fun getBundle() { | ||
| bundle = Bundle().apply { | ||
| putSerializable("key", Bear.RED) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
유저가 선택한 곰돌이 정보를 번들로 묶어서 보내주는 건가용?
There was a problem hiding this comment.
맞습니다! string 값이 아니라 bundle로 묶어서 보내고 잇습니다.
| performRoutineCompletion() | ||
| } | ||
|
|
||
| private fun setTextAndLottieByCottonType() { |
Comment on lines
+56
to
+59
| private fun setTextAlpha() { | ||
| binding.tvRoutineCompleteTitle.alpha = TRANSPARENT | ||
| binding.tvRoutineCompleteSubtitle.alpha = TRANSPARENT | ||
| } |
There was a problem hiding this comment.
글자가 서서히 나타나는 코드입니다! 사라지는 거는 1f -> 0f로만 숫자 순서를 바꿔주면 되겠네요
pump9918
approved these changes
Jan 14, 2024
| } | ||
|
|
||
| private fun setDailyRoutineImage() { | ||
| val bearDrawableMap = mapOf( |
There was a problem hiding this comment.
mapOf이 when문으로 묶는 것보다 효율적인가요??
There was a problem hiding this comment.
클린코드에서는 switch나 if, when등을 사용한 분기처리를 최대한 금하고 있습니다!
그래서 map으로 바꿔봤는데 사실 제가 보기엔 거기서 거기같긴 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_recording_20240115_001709.mp4
💬 To Reviewers