[ui] 행복루틴 진행 뷰 #53
Merged
[ui] 행복루틴 진행 뷰 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/sopetit/softie/domain/entity/HappyCard.kt # app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailActivity.kt # app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardPagerAdapter.kt # app/src/main/java/com/sopetit/softie/ui/happyroutine/adddetail/HappyDetailCardViewModel.kt # app/src/main/res/layout/activity_happy_add_detail.xml # app/src/main/res/layout/item_happy_add_detail_card.xml # app/src/main/res/values/strings.xml
stellar-halo
approved these changes
Jan 15, 2024
app/src/main/AndroidManifest.xml
Outdated
| @@ -20,7 +20,7 @@ | |||
| <activity | |||
| android:name=".ui.main.MainActivity" | |||
| android:exported="false" | |||
| android:screenOrientation="portrait" /> | |||
| android:screenOrientation="portrait"></activity> | |||
app/src/main/AndroidManifest.xml
Outdated
| android:name=".ui.dailyroutine.dailyroutineadd.DailyRoutineAddActivity" | ||
| android:name=".ui.happyroutine.addlist.HappyAddListActivity" | ||
| android:exported="false" | ||
| android:screenOrientation="portrait"></activity> |
There was a problem hiding this comment.
아직도 이런 실수를 반복하다니, 박호연 좀 혼나야할듯;
| } | ||
| } | ||
|
|
||
| private fun moveToIng() { | ||
| private fun moveToProgress() { |
minemi00
approved these changes
Jan 15, 2024
| private fun setCardEnter() { | ||
| with(binding) { | ||
| clHappyProgressCardFront.setOnClickListener { | ||
| setCardFlip(clHappyProgressCardFront, clHappyProgressCardBack) |
There was a problem hiding this comment.
setCardFilp이 카드 뒤집히는? 역할을 해주는건가요??
There was a problem hiding this comment.
네넵 VISIBLE 처리로 카드가 뒤집히는 것처럼 보이게 해놓은 거예요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_recording_20240115_035740.mp4
💬 To Reviewers