Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#57 [ui] 데일리루틴 추가하기 바텀시트 #60

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

minemi00
Copy link
Member

@minemi00 minemi00 commented Jan 15, 2024

📑 Work Description

  • 루틴 추가하기 버튼 누를시 바텀시트 작동
  • 추가하면 스낵바 띄워짐

🛠️ Issue

📷 Screenshot

Screen_recording_20240115_155718.mp4

💬 To Reviewers

사진이 좀 큰데 어차피 서버에서 받아오는거라 참고만 해주세요!

@minemi00 minemi00 self-assigned this Jan 15, 2024
@minemi00 minemi00 added UI ui 관련 작업 Pull Request pr 날림! 민회🐹 민회가 작업함! labels Jan 15, 2024
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Comment on lines +195 to +199
registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { result ->
if (result.resultCode == AppCompatActivity.RESULT_OK) {
snackBar(binding.root, getString(R.string.daily_routine_snack_bar))
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿이에용

Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당 👍

Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가자가자 다왔다~

binding.btnDailyRoutineAdd.setOnClickListener {
// TODO 서버통신 구현 후 imageUri 버전으로 수정

BindingBottomSheet.Builder().build(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

베이스가 워낙 잘 되어서 갖다쓰기 넘 편함

@minemi00 minemi00 merged commit dcb3625 into develop Jan 16, 2024
1 check passed
@minemi00 minemi00 deleted the feature/#57-daily-routine-add-bottom-sheet branch January 16, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request pr 날림! UI ui 관련 작업 민회🐹 민회가 작업함!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] 데일리루틴 추가하기 바텀시트
4 participants