#64 [feat] 행복 루틴 추가하기(목록) 뷰 API 연결 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-halo
requested changes
Jan 16, 2024
Comment on lines
+13
to
+20
| runCatching { happinessRoutineDataSource.getHappyChip() }.map { response -> | ||
| requireNotNull(response.data).toHappyChip() | ||
| } | ||
|
|
||
| override suspend fun getHappyContent(themeId: Int): Result<List<HappyContent>> = | ||
| runCatching { happinessRoutineDataSource.getHappyContent(themeId) }.map { response -> | ||
| requireNotNull(response.data).toHappyContent() | ||
| } |
There was a problem hiding this comment.
data class 내부 toHappyContent에서 map을 하고 있기 때문에 여기서 중복으로 해줄 필요는 없어 보입니다
There was a problem hiding this comment.
이 부분을 반영하지 못하고 머지를 해버렸습니다ㅜ 추후 QA에 이슈를 파서 작업하겠습니다. 죄송합니다.
minemi00
approved these changes
Jan 16, 2024
| val title: String, | ||
| val content: String, | ||
| @DrawableRes val imageUrl: Int, | ||
| val iconImageUrl: String, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
Screen_Recording_20240116_143230_Softie.mp4
💬 To Reviewers