Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#84 [feat] 로그아웃 구현 #87

Merged
merged 8 commits into from
Jan 18, 2024
Merged

Conversation

emjayMJkim
Copy link
Member

📑 Work Description

  • 로그아웃 구현

🛠️ Issue

📷 Screenshot

💬 To Reviewers

로그 아웃 후에 "로그인 화면->메인 화면"으로 가야 하는데 현재 "로그인 화면->온보딩"으로 넘어가는 문제가 있습니다. 이 부분은 서버에서 후에 저장된 멤버 정보가 있는지 여부를 내려주기로 해서 그 후에 로직 수정하겠습니다

@emjayMJkim emjayMJkim self-assigned this Jan 17, 2024
@emjayMJkim emjayMJkim added Pull Request pr 날림! Feat 새로운 기능 추가 민정🦊 민정이가 작업함! labels Jan 17, 2024
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 너무 잘해서 딱히 달 것이 업으네요..

Comment on lines +61 to +62
initSIgnUpStateUseCase(false)
initTokenUseCase("", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearLocalData 이런 식으로 함수화해도 좋을 것 같아요~

Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

양질의 코드

Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당!~!

@emjayMJkim emjayMJkim merged commit 0bebfcd into develop Jan 18, 2024
1 check passed
@emjayMJkim emjayMJkim deleted the feature/#84-auth-logout branch January 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 추가 Pull Request pr 날림! 민정🦊 민정이가 작업함!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 로그아웃
4 participants