#85 [hotfix] 홈 뷰 로티 수정 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minemi00
approved these changes
Jan 17, 2024
Comment on lines
+29
to
+32
| override fun getBearType(): String = localDataSource.bearType | ||
| override fun setBearType(bearType: String) { | ||
| localDataSource.bearType = bearType | ||
| } |
There was a problem hiding this comment.
코드는 어디선가 날라온 전부 남의 것,,,ㅎㅎ
| private val authRepository: AuthRepository | ||
| ) { | ||
| operator fun invoke(bearType: String) = | ||
| authRepository.setBearType(bearType) |
There was a problem hiding this comment.
앞으로 곰돌이가 필요하다면 써주세요!
pump9918
approved these changes
Jan 17, 2024
| } | ||
|
|
||
| private fun setDailyRoutineImage() { | ||
| val bearDrawableMap = mapOf( |
There was a problem hiding this comment.
mapOf 손이 잘 안갔는데 확실히 깔끔하네요
There was a problem hiding this comment.
저도 저번에 코리받고 수정했습니다!
| @@ -85,11 +87,12 @@ class HappyProgressFragment : | |||
| doBtnColor = R.drawable.shape_main1_fill_12_rect, | |||
| backBtnAction = {}, | |||
| doBtnAction = { | |||
| moveToHappyRoutineEmptyCardView() | |||
| startHappyRoutineCompleteActivity() | |||
There was a problem hiding this comment.
로티 달성 뷰로 연결시켜주셨군요! 감사합니다
emjayMJkim
approved these changes
Jan 17, 2024
Comment on lines
+26
to
+30
| val bearDrawableMap = mapOf( | ||
| BROWN to R.drawable.ic_bear_handsup_brown, | ||
| GRAY to R.drawable.ic_bear_handsup_gray, | ||
| RED to R.drawable.ic_bear_handsup_red, | ||
| WHITE to R.drawable.ic_bear_handsup_panda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
lottie.mp4
💬 To Reviewers