Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty password on SMB Dialog #4356

Open
wants to merge 1 commit into
base: release/4.0
Choose a base branch
from
Open

Empty password on SMB Dialog #4356

wants to merge 1 commit into from

Conversation

abdulroufsidhu
Copy link

@abdulroufsidhu abdulroufsidhu commented Feb 10, 2025 •
edited by VishnuSanal
Loading

Description

Issue tracker

Fixes #4354

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@VishnuSanal VishnuSanal changed the title #4354 fixed Empty password on SMB Dialog Feb 10, 2025
@VishnuSanal VishnuSanal added the pr-awaiting-initial-review this PR is awaiting for an initial review label Feb 10, 2025
@EmmanuelMess EmmanuelMess self-requested a review February 10, 2025 15:28
@EmmanuelMess
Copy link
Member

EmmanuelMess commented Feb 10, 2025 •
edited
Loading

Code looks okay. Will wait for CI to test.

@VishnuSanal
Copy link
Member

@abdulroufsidhu please run spotless (./gradlew spotlessApply`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmmanuelMess EmmanuelMess Awaiting requested review from EmmanuelMess

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
pr-awaiting-initial-review this PR is awaiting for an initial review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty password if possible
3 participants
@abdulroufsidhu @EmmanuelMess @VishnuSanal